Skip to content
Browse files

Better JMX for rollback() in RO Stores

  • Loading branch information...
1 parent 8c838e7 commit 7d5e323f6caefb78976d387a264eb0f2dbce01a4 @rsumbaly rsumbaly committed
Showing with 12 additions and 3 deletions.
  1. +12 −3 src/java/voldemort/store/readonly/ReadOnlyStorageEngine.java
View
15 src/java/voldemort/store/readonly/ReadOnlyStorageEngine.java
@@ -211,8 +211,7 @@ public void close() throws VoldemortException {
*
* @param newStoreDirectory The path to the new version directory
*/
- @JmxOperation(description = "swapFiles(newStoreDirectory) changes this store "
- + " to use the new data directory.")
+ @JmxOperation(description = "swapFiles changes this store to use the new data directory")
public void swapFiles(String newStoreDirectory) {
logger.info("Swapping files for store '" + getName() + "' to " + newStoreDirectory);
File newVersionDir = new File(newStoreDirectory);
@@ -322,9 +321,19 @@ public void run() {
/**
* Rollback to the specified push version
*
+ * @param rollbackToDir The full path of the version directory to rollback
+ * to
+ */
+ @JmxOperation(description = "Rollback to a previous version directory ( full path ) ")
+ public void rollback(String rollbackToDir) {
+ rollback(new File(rollbackToDir));
+ }
+
+ /**
+ * Rollback to the specified push version
+ *
* @param rollbackToDir The version directory to rollback to
*/
- @JmxOperation(description = "Rollback to a previous version")
public void rollback(File rollbackToDir) {
logger.info("Rolling back store '" + getName() + "'");
fileModificationLock.writeLock().lock();

0 comments on commit 7d5e323

Please sign in to comment.
Something went wrong with that request. Please try again.