Permalink
Browse files

Explicitly specified the boost:: namespace in the header files that g…

…et installed in the system

directories. This avoids ambiguities and namespace pollution.
  • Loading branch information...
1 parent 927373b commit a8ed5071eea5b95e2c78f062f84a0fa03d651cb1 Padraig committed Dec 12, 2009
@@ -56,9 +56,9 @@ class SocketStoreClientFactory: public StoreClientFactory
// StoreClientFactory interface
virtual StoreClient* getStoreClient(const std::string& storeName);
virtual StoreClient* getStoreClient(const std::string& storeName,
- shared_ptr<InconsistencyResolver>& resolver);
+ boost::shared_ptr<InconsistencyResolver>& resolver);
virtual Store* getRawStore(const std::string& storeName,
- shared_ptr<InconsistencyResolver>& resolver);
+ boost::shared_ptr<InconsistencyResolver>& resolver);
private:
/** Internal implementation details */
@@ -30,8 +30,6 @@
namespace Voldemort {
-using namespace boost;
-
/**
* Represents a connection to a Voldemort cluster and can be used to
* create @ref StoreClient instances to interact with individual
@@ -70,7 +68,7 @@ class StoreClientFactory
* @see getStoreClient(std::string&)
*/
virtual StoreClient* getStoreClient(const std::string& storeName,
- shared_ptr<InconsistencyResolver>& resolver) = 0;
+ boost::shared_ptr<InconsistencyResolver>& resolver) = 0;
/**
* Get the underlying store, not the public StoreClient interface.
@@ -85,7 +83,7 @@ class StoreClientFactory
* @return the appropriate store
*/
virtual Store* getRawStore(const std::string& storeName,
- shared_ptr<InconsistencyResolver>& resolver) = 0;
+ boost::shared_ptr<InconsistencyResolver>& resolver) = 0;
};

0 comments on commit a8ed507

Please sign in to comment.