Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Fixed E2E non blocking checkout test to actually check for non-blocki…

…ng checkouts. (Addresses review feedback from Chinmay Soman.)
  • Loading branch information...
commit e372717cd7f832e4eb59d997f04de656a906cc86 1 parent 4e6e8b4
@jayjwylie jayjwylie authored
View
16 test/integration/voldemort/nonblocking/E2ENonblockingCheckoutTest.java
@@ -244,26 +244,18 @@ public void run() {
+ Thread.currentThread().getName() + ")");
System.out.println("START " + context);
long startTimeMs = System.currentTimeMillis();
- boolean putDone = false;
- while(!putDone) {
- try {
- storeClient.put(I, I);
- putDone = true;
- } catch(ObsoleteVersionException e) {
- System.out.println("RETRY " + context);
- // What to do here?
- }
+ try {
+ storeClient.put(I, I);
+ } catch(ObsoleteVersionException e) {
+ System.out.println("ObsoleteVersionException caught on put." + context);
}
long endTimeMs = System.currentTimeMillis();
System.out.println(" DONE " + context + " --- Time (ms): "
+ (endTimeMs - startTimeMs));
if(i >= NUM_EXEMPT_PUTS) {
- /*-
assertFalse("Operation completes without blocking on slow server:"
+ (endTimeMs - startTimeMs),
(endTimeMs - startTimeMs) > this.putTimeLimitMs);
- */
- assertFalse("False", false); // noop until fix
if((endTimeMs - startTimeMs) > this.putTimeLimitMs) {
System.err.println("Operation blocked! Therefore, operation is not nonblocking... "
+ context
Please sign in to comment.
Something went wrong with that request. Please try again.