Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 4, 2015
  1. Xu Ha
Commits on Jan 31, 2015

    Test fixes

    arunthirupathi authored
    1) Sometimes starting the voldemort server fails with the error
    ObsoleteVersion Exception. This is an override only used by the tests,
    so it is safe to modify it.
    2) On Java 8, ConsistencyFetcher test fails as the set has a different
    ordering, probably because of the hashCode implementation difference. In
    this method ordering is not important so I modified the test to ignore
    the ordering.
Commits on Jan 22, 2015

    Read after truncate crashes the JVM

    arunthirupathi authored
    If you truncate a read-only store and send read operations get/getall
    for one of the existent keys it crashes the JVM with SegFault. Some of
    the data is cached in java collections and it tries to access the memory
    mapped file which has been closed by the truncate. This causes the JVM
    to crash. Now the java collections are cleared and the code tries to
    handle this gracefully.  But this is not an ideal code more of a
    Fixed spewing of log messages to the standard output, as they are
    already captured in the log4j loggers.
    Added unit test for the read after truncate scenario.
Commits on Jan 9, 2015

    ReplaceNodeCLI enhancements and tests

    arunthirupathi authored
    1) Made ReplaceNodeCLI unit testing friendly, removed System.exits
    with throw Exception and quitting in the main method instead of each
    2) Added post condition checks to the ReplaceNodeCLI to verify for
    consistent stores.xml and cluster.xml.
    Added the testing for ReplaceNode
    1) Check if a node can be swapped when it is down
    2) Check if a node can be swapped when it is up
    3) Check if you can move a hard disk and replace a node down
    While doing the tests, there are many client threads simulating the
    traffic to make sure that they dont see any exceptions.
Commits on Jan 7, 2015

    Share the constant for cluster.xml, stores.xml

    arunthirupathi authored
    Share the same Constant from SystemStoreConstants for stores.xml
    cluster.xml and metadata-versions. Previously each class declared its
    own constant and searching for the usage within the source was a
    nightmare. I had to do multiple file searches to piece together
    information. This will help in the future to make the dependencies
    easier to track.

    Refactoring the test cases

    arunthirupathi authored
    Further refactored the test cases. Tried to solidify the test case
    by adding more checks and saw that most of them failed because of
     existing bugs. So commented them out and left whatever comments
    I know of in those places.
Commits on Dec 30, 2014
Commits on Dec 18, 2014
  1. Xu Ha

    Refactor the traffic generator

    arunthirupathi authored
    Refactored the traffic generator into its own class.

    Move slop drain function to server test utils

    arunthirupathi authored
    Moved the slop drain function to server test utils.
Commits on Dec 13, 2014
  1. Xu Ha

    Productionize ReadOnlyReplicationHelper

    cshaxu authored
    - Rename ReadOnlyHostSwapCLI -> REadOnlyReplicationHelper
    - Create unit test to verify the correctness
    - Change input from Cluster to BootstrapUrl to fit admin environment
    - Fix bugs and re-format help menu
  2. Xu Ha
Commits on Dec 9, 2014

    Refactor Client Traffic Verifier into its own class

    arunthirupathi authored
    Refactored the client traffic verifier into its own class.
    No code change is done. This is just moving code into a new seperate
    class file and renaming the instantiation and references.
    Other refactorings will follow this checkin.
  2. Xu Ha
Commits on Nov 5, 2014
  1. Xu Ha
  2. Xu Ha
  3. Xu Ha
  4. Xu Ha
  5. Xu Ha

    add OFFLINE_SERVER state

    cshaxu authored
Commits on Oct 7, 2014
  1. Bhavani Sudha Saktheeswaran
  2. Bhavani Sudha Saktheeswaran
Commits on Oct 3, 2014
  1. Bhavani Sudha Saktheeswaran
Commits on Sep 27, 2014
  1. Bhavani Sudha Saktheeswaran

    * Refactoring the CoordinatorProxyService initialize fat clients methods

    bhasudha authored
    * Fixing StoreClientConfigService and refactoring FileBasedStoreClientConfigService
    * Fixing Coordinator unit tests
Commits on Sep 19, 2014
  1. Xu Ha
Commits on Sep 17, 2014

    Cleanup query keys output of Admin tool

    arunthirupathi authored
    1) Previously when the value bytes can't be deserialized it errored out
    immediately and it does not print values of other nodes. You can do node
    by node, but failed nodes can never be retrieved. Now if it fails, byte
    array output will be printed.
    2) When node does not have a key, it printed invalid metadata
    exceptions for all other nodes. Now they are skipped in the output.
    3) Does not report what all nodes had same value and which ones

    Adding comments to illustrate a problem

    arunthirupathi authored
    No code change.
Commits on Sep 16, 2014
  1. Felix GV
Commits on Sep 10, 2014
  1. singhsiddharth Xu Ha

    More refactoring - rename classes etc

    singhsiddharth authored cshaxu committed
Commits on Sep 5, 2014

    QuotaException causes delete failure

    arunthirupathi authored
    1) When QuotaException is thrown by delete, it fails the delete instead
    of Quorum to decide the failure.
    2) Added unit test to cover some part of the delete test case.
Commits on Aug 27, 2014

    Slop for delete operations

    arunthirupathi authored
    1) Exception handling of delete is very different at 4 places ( on
    normal response, required failure, quorum failure) and after pipeline is
    2) The exceptions are reported again and again ( They are not removed
    from the map).
    3) Some places ignore obsoleteVersionException, some others report it.
    4) There is a zombie state abort, there is no way to reach this state.
    5) Multiple slops could be sent, because of the issue 2. When the
    pipeline is aborted, no slops could be sent.
    6) Refactored QuotaLimitingStore test to add delete test cases
    7) Combined the PUT and GET quotas into 2 quotas.
    Defined a common method, so that all 4 places call into the same method.
    Only the condition for calling is different. Race conditions still
    exist, after zone failure check but before pipeline finishes the
    exception will go missing, slops will not happen, but the chances are
    Got rid of the state PerformDeletedHintHandoff as
    QuotaExceededExceptions will not be reported as failures. Now doing it
    in place.
Commits on Aug 18, 2014
  1. Xu Ha
Commits on Aug 14, 2014
  1. Felix GV
Commits on Aug 13, 2014

    Zone check, store name in error, unit tests

    arunthirupathi authored
    1) When Server fails to start because of an invalid store, the store is
    logged in the error message. So that it is actionable.
    2) Added checks to zone proximity list to avoid same zone and duplicate
    zone ids.
    3) Modified Zones from LinkedList to ArrayList, as get operation is more
    efficient in ArrayList than the LinkedList.
    4) Refactor the common code in zone calculations to common functions.
    5) Added unit tests to cover the new checks added to zone proximity
Commits on Aug 12, 2014

    Merge conflict was incorrectly resolved

    arunthirupathi authored
    Fixed the merge conflict

    Merge conflict on StatsTest

    arunthirupathi authored
    Resolved the merge conflict
Something went wrong with that request. Please try again.