Skip to content
Commits on Jan 15, 2013
  1. @jayjwylie
  2. @jayjwylie
  3. @jayjwylie
  4. @jayjwylie

    Reverted refactoring of PerformParallel* classes committed in f37b25e…

    jayjwylie committed Dec 4, 2012
  5. @jayjwylie

    Moved stress test for connection checkout/checkin and failure detecto…

    jayjwylie committed Dec 4, 2012
    …r to long unit test. Cleaned up comments in ClientRequestExecutorPool to make intended semantics clearer.
  6. @jayjwylie
  7. @jayjwylie

    Minor changes to tests

    jayjwylie committed Dec 3, 2012
    - renamed base keyedresourcepool test to avoid pattern that ant/junit uses to try and run tests.
    - tweaked stress tests parameters once more to make it easier to run locally.
  8. @jayjwylie

    Substantial refactoring of (Queued)KeyedResourcePool tests.

    jayjwylie committed Dec 3, 2012
    - factored out a common base class in which all of the nested helper classes are defined
    - separated out the various types of tests into files:
      - simple/basic tests
      - contention tests that spawn threads to generate contention
      - specific race condition test
    - The specific race condition test for KeyedResourcePool shows that google issue 276 is resolved:
  9. @jayjwylie
  10. @jayjwylie
  11. @jayjwylie
  12. @jayjwylie
  13. @jayjwylie

    Added stress test and cleaned up client request executor pool reset.

    jayjwylie committed Nov 30, 2012
    - changed behavior to match original KeyedResourcePool implementation. The original QueuedKeyedResourcePool.reset() was an unnecessary/bad behavior change that canceled enqueued requests. The original behavior was to destroy idle resources whenever pool is reset.
    - stress test that has put and get threads contend for slow servers in such a manner as to trigger failure detection to mark nodes unavailable. This excercises connection tear down, reset(), and build up again. This also exercises the code paths in which callbacks do heavyweight work.
  14. @jayjwylie

    Interim checkin with an ugly example of how threads could be created …

    jayjwylie committed Nov 30, 2012
    …to handle callback work. The ugly code is commented out.
  15. @jayjwylie

    Refactor all PerformParallel*Request classes.

    jayjwylie committed Nov 29, 2012
    - got rid of anonymous call back classes
    - factored out waitForResponses logic and processResponses logic for most of these classes. GetAll stands out as being fairly different from the others.
    - did not refactor to the point of sharing common code across classes, just refactored within each class.
    - added many TODOs to the code for further refactoring.
  16. @jayjwylie

    Reduce granularity of failure detector locking and do not destroy all…

    jayjwylie committed Nov 28, 2012
    … enqueued requests upon setUnavailable.
    - Reduce amount of work done within synchronized section to reduce lock granularity and so ensure "side effects" of node being marked (un)available are not w/in sync section.
    - Added TODO/comment to decide whether we want to actively destroy all connections upon node being marked unavailable
    - Switched behavior to lazily destroying connections.
  17. @jayjwylie

    Less verbose logging in the face of expected exceptions and error log…

    jayjwylie committed Nov 28, 2012
    …ging in the face of a slop not being written.
    - less verbose logging when a node is unavailable
    - less verbose logging in the face of expected "exceptional" responses.
    - ensure that an error message is logged if a slop is not written (we can grep for "Slop write of key.*was not written" in logs)
    - added TODO because ObsoleteVersionExceptiosn are neither treated as failures or successes in the callback to sendHintParallel.
    - minor fix
    - from junit3 to junit4
  18. @jayjwylie

    Minor code clean up based on review feedback

    jayjwylie committed Nov 16, 2012
    Protected all logger.(debug|info) statements I added with an is(Debug|Info)Enabled() check.
    Made AsyncRecoveryFailureDetector less verbose. When it polls a server to see if it is available, it now prints out a clean INFO level message. It had been printing out a WARN level message *with* a stacktrace that made this expected behavior look much scarier than it really is.
  19. @jayjwylie
  20. @jayjwylie
  21. @jayjwylie

    Added INFO level messages to better understand the performance of per…

    jayjwylie committed Nov 13, 2012
    …-request instrumentation. Expect to remove most of this after debugging.
  22. @jayjwylie
  23. @jayjwylie
  24. @jayjwylie

    Added INFO level messages to better understand resetting stats in Cli…

    jayjwylie committed Nov 12, 2012
    …entSocketStats. Expect to remove this after debugging.
  25. @jayjwylie

    Added INFO level messages to better understand connection creation. E…

    jayjwylie committed Nov 12, 2012
    …xpet to remove most of this after debugging.
    - print out time to establish connection (if it takes longer than 1 ms)
    - print out info about object creation (connection establishment). In
      particular, how many outstanding creations (connection
      establishments) are in flight and how many idle resources are in the
      pool after the newly created resource is checked in.
  26. @jayjwylie

    Added INFO level messages to better understand statistics tracking (S…

    jayjwylie committed Nov 12, 2012
    …toreStats, SocketClientStats, Histogram) behavior. Expect to remove most of these messages after debugging.
    - one more check to harden the imnplementation of insert
    - durationMs from int to long
    - print out timing of histogram reset (q95, q99, reset)
  27. @jayjwylie

    Fixed Histogram: halved memory footprint, test boundary conditions, d…

    jayjwylie committed Nov 12, 2012
    …ropped unnecessary binary search.
    These changes preserve/correct behavior of the current Histogram.
    - Halved memory footprint by dropping unnecessary "bounds" array
    - Dropped unnecessary binary search, making insert O(1) rather than O(log(nBuckets))
    - Improved documentation
    - Made interface consistent for type of values inserted/got from histogram (i.e., all are 'long')
    - Added tests for boundary conditions: -ive values are dropped on
      insert, "too large" values are bucketed in the final bucket on
    Minor fixes to RequestCounter calls to histogram to conform to 'long' interfaces.
  28. @jayjwylie
  29. @jayjwylie

    Changed reset and destroyRequestQueue to avoid any heavy weight synch…

    jayjwylie committed Nov 8, 2012
    …ronization methods. This should fix deadlock issue.
  30. @jayjwylie

    Change async checkout behavior to be more like sync checkout: only c…

    jayjwylie committed Nov 8, 2012
    …reate resources (connections) when they are needed.
        Now, connections should only be created on demand. The initial code created connections until the max limit of the pool was
        Some minor tweaks to test that confirm the desired behavior at a unit test level.
  31. @vinothchandar
Commits on Jan 14, 2013
  1. @vinothchandar
  2. Bug fixes in HdfsFetcher revealed by HdfsFetcherTest (NPE and hiding …

    Chinmay Soman committed Jan 13, 2013
    …the VoldemortSerializationException)
Commits on Jan 12, 2013
  1. @vinothchandar

    Minor debug fixes

    vinothchandar committed Jan 11, 2013
Commits on Jan 11, 2013
  1. Fixing .classpath which had the wrong hadoop-core version. Also chang…

    Chinmay Soman committed Jan 11, 2013
    …ed the Mlock related info messages to debug.
Something went wrong with that request. Please try again.