Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes two bugs: put that returns a version, delete shall behave like put instead of get #45

Merged
5 commits merged into from Mar 15, 2011

Conversation

Projects
None yet
3 participants
Collaborator

leigao commented Mar 15, 2011

Bug 1: Modified the Voldemort Client 'put' API to return a version instead of void.
Bug 2: PipelinedRoutedStore treats 'delete' as 'get'. The fix change the semantics of 'delete' to be similar to 'put'.

Added unit tests for both bug fixes.

Can you update the java docs of it as well?

I think you can remove this check totally....

Contributor

afeinberg commented Mar 15, 2011

Changing the signature (to return a version) while retaining the same method name will break backwards compatibility, due to the way JVM invokes the method (with a signature). This means any clients compiling in Voldemort, will need to be recompiled.

(Please fix-- this will update the pull request)

am assuming this is removed in the next commit...

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment