Upgrade to httpclient 4.x from commons-httpclient 3.0.x #61

Merged
merged 21 commits into from Jan 1, 2012

3 participants

@akkumar
  • Upgrade to httpclient 4.x (from commons-httpclient 3.0.x )
@afeinberg

Looking at this now -- since we are no longer using HTTP based StoreSwapper (and will remove this class) this should be safe for use within LinkedIn. Would there be compatibility issues for others who still have old HTTP client elsewhere in their CLASSPATH?

I am for merging this -- this fixes many bugs -- but we should have some update procedures listed in case there are going to be CLASSPATH/backwards compatibility issues in the update (they are fine, as long as they are documented, and a roll out plan can be created).

Thanks,

  • Alex
@ijuma
Collaborator

httpclient 4.x uses a different package than 3.x

@afeinberg

Okay merging.

@afeinberg afeinberg merged commit ce113ee into voldemort:master Jan 1, 2012
@ijuma
Collaborator

By the way, I just noticed that this pull request includes a lot of reverts. In my opinion, this is undesirable and I believe we should ask these to be cleaned up before merging (or do it ourselves).

@afeinberg
@ijuma
Collaborator

Great Alex, thanks!

@akkumar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment