Upgrade to httpclient 4.x from commons-httpclient 3.0.x #61

Merged
merged 21 commits into from Jan 1, 2012

Projects

None yet

3 participants

@akkumar
Contributor
akkumar commented Dec 30, 2011
  • Upgrade to httpclient 4.x (from commons-httpclient 3.0.x )
@afeinberg
Contributor

Looking at this now -- since we are no longer using HTTP based StoreSwapper (and will remove this class) this should be safe for use within LinkedIn. Would there be compatibility issues for others who still have old HTTP client elsewhere in their CLASSPATH?

I am for merging this -- this fixes many bugs -- but we should have some update procedures listed in case there are going to be CLASSPATH/backwards compatibility issues in the update (they are fine, as long as they are documented, and a roll out plan can be created).

Thanks,

  • Alex
@ijuma
Collaborator
ijuma commented Jan 1, 2012

httpclient 4.x uses a different package than 3.x

@afeinberg
Contributor

Okay merging.

@afeinberg afeinberg merged commit ce113ee into voldemort:master Jan 1, 2012
@ijuma
Collaborator
ijuma commented Jan 2, 2012

By the way, I just noticed that this pull request includes a lot of reverts. In my opinion, this is undesirable and I believe we should ask these to be cleaned up before merging (or do it ourselves).

@afeinberg
Contributor

I agree, we should ask that the requests be rebased going forward. Sorry for the oversight on my part.

  • af

On Monday, 2 January 2012 at 7:22:44 -0800, Ismael Juma wrote:

By the way, I just noticed that this pull request includes a lot of reverts. In my opinion, this is undesirable and I believe we should ask these to be cleaned up before merging (or do it ourselves).


Reply to this email directly or view it on GitHub:
#61 (comment)

@ijuma
Collaborator
ijuma commented Jan 2, 2012

Great Alex, thanks!

@akkumar
Contributor
akkumar commented Jan 3, 2012

My bad, sorry, about the same.

On Mon, Jan 2, 2012 at 11:10 AM, Ismael Juma <
reply@reply.github.com

wrote:

Great Alex, thanks!


Reply to this email directly or view it on GitHub:
#61 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment