Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Upgrade to httpclient 4.x from commons-httpclient 3.0.x #61

Merged
merged 21 commits into from

3 participants

@akkumar
  • Upgrade to httpclient 4.x (from commons-httpclient 3.0.x )
@afeinberg
Collaborator

Looking at this now -- since we are no longer using HTTP based StoreSwapper (and will remove this class) this should be safe for use within LinkedIn. Would there be compatibility issues for others who still have old HTTP client elsewhere in their CLASSPATH?

I am for merging this -- this fixes many bugs -- but we should have some update procedures listed in case there are going to be CLASSPATH/backwards compatibility issues in the update (they are fine, as long as they are documented, and a roll out plan can be created).

Thanks,

  • Alex
@ijuma
Collaborator

httpclient 4.x uses a different package than 3.x

@afeinberg
Collaborator

Okay merging.

@afeinberg afeinberg merged commit ce113ee into voldemort:master
@ijuma
Collaborator

By the way, I just noticed that this pull request includes a lot of reverts. In my opinion, this is undesirable and I believe we should ask these to be cleaned up before merging (or do it ourselves).

@afeinberg
Collaborator
@ijuma
Collaborator

Great Alex, thanks!

@akkumar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Dec 30, 2011
  1. @akkumar

    thrift 0.5.0 to 0.8.0

    akkumar authored
  2. @akkumar
  3. @akkumar
  4. @akkumar

    specify bootclasspath

    akkumar authored
  5. @akkumar
  6. @akkumar
Commits on Dec 31, 2011
  1. @akkumar
  2. @akkumar
  3. @akkumar
  4. @akkumar
  5. @akkumar

    Release httpclient resources

    akkumar authored
  6. @akkumar
  7. @akkumar

    socket buffer size maintained by the app as opposed to relying on so_…

    akkumar authored
    …rcvbuf dependent on the implementation
  8. @akkumar
  9. @akkumar

    fix bug in last read

    akkumar authored
  10. @akkumar

    ignore sourcepath

    akkumar authored
  11. @akkumar

    Revert "specify bootclasspath"

    akkumar authored
    This reverts commit e22c162.
  12. @akkumar

    Revert "remove unnecessary echo statements"

    akkumar authored
    This reverts commit 3a64322.
  13. @akkumar

    Revert "cross compile with jdk7 compiler"

    akkumar authored
    This reverts commit d23c317.
  14. @akkumar

    evert "thrift 0.5.0 to 0.8.0"

    akkumar authored
    This reverts commit a511e3d.
  15. @akkumar
Something went wrong with that request. Please try again.