Removed test-view from config/single_node_cluster #87

Merged
merged 1 commit into from Aug 6, 2012

Conversation

Projects
None yet
2 participants
@zsimic
Contributor

zsimic commented Jul 24, 2012

Starting a server as described in http://project-voldemort.com/quickstart.php fails when test-view is defined in config/single_node_cluster

@ghost ghost assigned jayjwylie Jul 31, 2012

@jayjwylie

This comment has been minimized.

Show comment
Hide comment
@jayjwylie

jayjwylie Aug 3, 2012

Contributor

OK. I can reproduce this behavior.
$ cd voldemort
$ ant jar
$ bin/voldemort-server.sh config/single_node_cluster

xception in thread "main" java.lang.IllegalArgumentException: java.lang.ClassNotFoundException: voldemort.store.views.UpperCaseView
at voldemort.utils.ReflectUtils.loadClass(ReflectUtils.java:59)
at voldemort.store.views.ViewStorageConfiguration.loadTransformation(ViewStorageConfiguration.java:86)
at voldemort.store.views.ViewStorageConfiguration.getStore(ViewStorageConfiguration.java:59)
at voldemort.server.storage.StorageService.openStore(StorageService.java:338)
at voldemort.server.storage.StorageService.startInner(StorageService.java:294)
at voldemort.server.AbstractService.start(AbstractService.java:62)
at voldemort.server.VoldemortServer.startInner(VoldemortServer.java:255)
at voldemort.server.AbstractService.start(AbstractService.java:62)
at voldemort.server.VoldemortServer.main(VoldemortServer.java:307)
Caused by: java.lang.ClassNotFoundException: voldemort.store.views.UpperCaseView
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:169)
at voldemort.utils.ReflectUtils.loadClass(ReflectUtils.java:57)
... 8 more

But, then if I do the following:
$ ant test
$ bin/voldemort-server.sh config/single_node_cluster
Everything works fine.

I need to figure out if the best thing is to (i) clean up quickstart documentation, (ii) clean up ant build dependencies, or (iii) remove the test-view from config/single_node_cluster/config/stores.xml as per your pull request.

If you could confirm that everything works for you once you do 'ant test', that would be helpful.

Thanks!
-Jay

Contributor

jayjwylie commented Aug 3, 2012

OK. I can reproduce this behavior.
$ cd voldemort
$ ant jar
$ bin/voldemort-server.sh config/single_node_cluster

xception in thread "main" java.lang.IllegalArgumentException: java.lang.ClassNotFoundException: voldemort.store.views.UpperCaseView
at voldemort.utils.ReflectUtils.loadClass(ReflectUtils.java:59)
at voldemort.store.views.ViewStorageConfiguration.loadTransformation(ViewStorageConfiguration.java:86)
at voldemort.store.views.ViewStorageConfiguration.getStore(ViewStorageConfiguration.java:59)
at voldemort.server.storage.StorageService.openStore(StorageService.java:338)
at voldemort.server.storage.StorageService.startInner(StorageService.java:294)
at voldemort.server.AbstractService.start(AbstractService.java:62)
at voldemort.server.VoldemortServer.startInner(VoldemortServer.java:255)
at voldemort.server.AbstractService.start(AbstractService.java:62)
at voldemort.server.VoldemortServer.main(VoldemortServer.java:307)
Caused by: java.lang.ClassNotFoundException: voldemort.store.views.UpperCaseView
at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:301)
at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
at java.lang.Class.forName0(Native Method)
at java.lang.Class.forName(Class.java:169)
at voldemort.utils.ReflectUtils.loadClass(ReflectUtils.java:57)
... 8 more

But, then if I do the following:
$ ant test
$ bin/voldemort-server.sh config/single_node_cluster
Everything works fine.

I need to figure out if the best thing is to (i) clean up quickstart documentation, (ii) clean up ant build dependencies, or (iii) remove the test-view from config/single_node_cluster/config/stores.xml as per your pull request.

If you could confirm that everything works for you once you do 'ant test', that would be helpful.

Thanks!
-Jay

@jayjwylie

This comment has been minimized.

Show comment
Hide comment
@jayjwylie

jayjwylie Aug 6, 2012

Contributor

Removing test-view from config/single_node_cluster/config/stores.xml seems like the right thing to do. The unit test voldemort.store.views.ViewStorageEngineTest relies on test-view being defined in /test/common/voldemort/config/view-store.xml. Nothing else seems to depend upon 'test-view' being defined, let alone 'test-view' being defined in config/single_node_cluster/config/stores.xml.

Contributor

jayjwylie commented Aug 6, 2012

Removing test-view from config/single_node_cluster/config/stores.xml seems like the right thing to do. The unit test voldemort.store.views.ViewStorageEngineTest relies on test-view being defined in /test/common/voldemort/config/view-store.xml. Nothing else seems to depend upon 'test-view' being defined, let alone 'test-view' being defined in config/single_node_cluster/config/stores.xml.

jayjwylie added a commit that referenced this pull request Aug 6, 2012

Merge pull request #87 from zsimic/master
Removed test-view from config/single_node_cluster

@jayjwylie jayjwylie merged commit 1935c65 into voldemort:master Aug 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment