New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to libjson-c >=0.12 #106

Merged
merged 1 commit into from Jan 15, 2015

Conversation

Projects
None yet
3 participants
@mbehr1
Contributor

mbehr1 commented Jan 8, 2015

  • Update to libjson-c >=0.12 to get rid of the deprecated functions (see #72)
    (probably libjson-c >=0.10 is sufficient but the CI tests on travis-ci are configured for 0.12)
  • This breaks compatibility with libjson0-dev,.... Needs libjson-c2 and/or libjson-c-dev!

(replacing #82. I prefered this instead of resetting #82 as the history was quite long.)

@mbehr1 mbehr1 referenced this pull request Jan 8, 2015

Closed

change to libjson-c >=0.12 #82

@andig

This comment has been minimized.

Contributor

andig commented Jan 9, 2015

Danke, werd das einmal testen und dann mergen.

@andig

This comment has been minimized.

Contributor

andig commented Jan 9, 2015

Need to update dependecies/ wiki. From #82- either

git clone -b json-c-0.12 https://github.com/json-c/json-c
cd json-c
sh autogen.sh
./configure
make
sudo make install

or

but the raspbian libjson-c from jessie seems to work fine on wheezy, so they could just install that:

root@raspberrypi:~# cat /etc/apt/sources.list
#deb http://mirrordirector.raspbian.org/raspbian/ wheezy main contrib non-free rpi
deb http://mirrordirector.raspbian.org/raspbian/ jessie main contrib non-free rpi
root@raspberrypi:~# apt-get install --reinstall --print-uris libjson-c-dev libjson-c2
http://mirrordirector.raspbian.org/raspbian/pool/main/j/json-c/libjson-c2_0.11-4_armhf.deb
http://mirrordirector.raspbian.org/raspbian/pool/main/j/json-c/libjson-c-dev_0.11-4_armhf.deb
@r00t-

This comment has been minimized.

Contributor

r00t- commented Jan 15, 2015

why is this not merged yet?
i wouldn't update the docs before it's even merged.

+1

@andig

This comment has been minimized.

Contributor

andig commented Jan 15, 2015

@r00t- would you take care of the docs?

r00t- added a commit that referenced this pull request Jan 15, 2015

@r00t- r00t- merged commit b3d5bd9 into volkszaehler:master Jan 15, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@andig

This comment has been minimized.

Contributor

andig commented Jan 17, 2015

Tolle Idee. Jetzt haben wir einen Stand der sich gemäß Wiki nicht mehr kompilieren lässt. Genau da sehe ich die Verantwortung eines Committers- Umsicht und Nachhaltigkeit.

Andreas

Am 15.01.2015 um 18:39 schrieb r00t- notifications@github.com:

Merged #106.


Reply to this email directly or view it on GitHub.

@r00t-

This comment has been minimized.

Contributor

r00t- commented Jan 17, 2015

oh nein!

@mbehr1 mbehr1 deleted the mbehr1:rebased_fix_72_json-c_0.12 branch Mar 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment