Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long delay when exiting the add command #163

Closed
dnarvaez opened this issue May 26, 2013 · 0 comments
Closed

Long delay when exiting the add command #163

dnarvaez opened this issue May 26, 2013 · 0 comments
Milestone

Comments

@dnarvaez
Copy link

When I run volo add in my project, the dependencies installation ends pretty quickly but then I see a > 1 minute delay before the command exits. Everything is apparently already done when it hangs, the okText in the volo script has been printed. The following patch seems to solves it but, knowing very little about promises, it doesn't feel like the right fix.

@@ -15,6 +15,7 @@ var args = [].splice.call(process.argv, 2);
     if (okText) {
         console.log(okText);
     }
+    process.exit(0);
 }, function (errText) {
     console.log('ERROR: ' + errText);
     process.exit(1);

My node version is v0.10.8, volo git master, debian jessy.

@jrburke jrburke closed this as completed in 10e905c Jun 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant