From bceb0a0c740cd01a3a36b4d6cbe3797b16281fa4 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:36:12 +0200
Subject: [PATCH 01/29] update engine version

---
 src/Platform.php | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/src/Platform.php b/src/Platform.php
index a2bb622..2d51361 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -6,7 +6,7 @@ class Platform
 {
     private const BINARY_NAME = 'volt-test';
 
-    private const ENGINE_CURRENT_VERSION = 'v0.0.1';
+    private const ENGINE_CURRENT_VERSION = 'v0.1.0';
     private const BASE_DOWNLOAD_URL = 'https://github.com/volt-test/binaries/releases/download';
     private const SUPPORTED_PLATFORMS = [
         'linux-amd64' => 'volt-test-linux-amd64',
@@ -214,4 +214,17 @@ public static function getBinaryPath(): string
 
         return $binaryPath;
     }
+
+    private static function needsUpdate(): bool
+    {
+        $binDir = self::getBinaryDir();
+        $versionFile = $binDir . '/.volt-test-version';
+
+        if (!file_exists($versionFile)) {
+            return true;
+        }
+
+        $currentVersion = trim(file_get_contents($versionFile));
+        return $currentVersion !== self::ENGINE_CURRENT_VERSION;
+    }
 }

From 690810559e63ef14d7876d7ec2b881621b349446 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:48:48 +0200
Subject: [PATCH 02/29] Adding test for volt test to check different os

---
 tests/VoltTestTest.php | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)
 create mode 100644 tests/VoltTestTest.php

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
new file mode 100644
index 0000000..e81eab7
--- /dev/null
+++ b/tests/VoltTestTest.php
@@ -0,0 +1,37 @@
+<?php
+
+namespace Tests;
+
+use PHPUnit\Framework\TestCase;
+use VoltTest\Exceptions\ErrorHandler;
+use VoltTest\VoltTest;
+
+class VoltTestTest extends TestCase
+{
+    protected function setUp(): void
+    {
+        parent::setUp();
+        // Ensure error handlers are registered at the start of each test
+        ErrorHandler::register();
+    }
+
+    protected function tearDown(): void
+    {
+        // Clean up error handlers after each test
+        ErrorHandler::unregister();
+        parent::tearDown();
+    }
+    public function testVoltTest()
+    {
+        $voltTest = new VoltTest("test");
+        $voltTest->setVirtualUsers(10);
+        $scenario1 = $voltTest->scenario("Test Scenario")->setWeight(10);
+        $scenario1->step("Step 1")->get('https://www.google.com');
+        $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
+        $scenario2->step("Step 1")->get('https://www.google.com');
+        $result = $voltTest->run();
+        $this->assertNotEmpty($result->getRawOutput(), "Raw output is empty");
+        $this->assertGreaterThan(0, $result->getDuration(), "Duration is not greater than 0");
+        $this->assertGreaterThan(0, $result->getAvgResponseTime(), "Average response time is not greater than 0");
+    }
+}
\ No newline at end of file

From 8825e9b3698aeff0e383e36262d0b10f5c9e059f Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:49:56 +0200
Subject: [PATCH 03/29] remove unused code

---
 src/Platform.php | 13 -------------
 1 file changed, 13 deletions(-)

diff --git a/src/Platform.php b/src/Platform.php
index 2d51361..9776569 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -214,17 +214,4 @@ public static function getBinaryPath(): string
 
         return $binaryPath;
     }
-
-    private static function needsUpdate(): bool
-    {
-        $binDir = self::getBinaryDir();
-        $versionFile = $binDir . '/.volt-test-version';
-
-        if (!file_exists($versionFile)) {
-            return true;
-        }
-
-        $currentVersion = trim(file_get_contents($versionFile));
-        return $currentVersion !== self::ENGINE_CURRENT_VERSION;
-    }
 }

From d3f12ad3a13931bfb85cb414ab87c1486eca5ae7 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:51:44 +0200
Subject: [PATCH 04/29] ci

---
 tests/VoltTestTest.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index e81eab7..ce8b79d 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -34,4 +34,4 @@ public function testVoltTest()
         $this->assertGreaterThan(0, $result->getDuration(), "Duration is not greater than 0");
         $this->assertGreaterThan(0, $result->getAvgResponseTime(), "Average response time is not greater than 0");
     }
-}
\ No newline at end of file
+}

From baa40b46fefe49226123d25e911b8e56c749c695 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:54:52 +0200
Subject: [PATCH 05/29] view output of test

---
 tests/VoltTestTest.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index ce8b79d..6063d43 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -29,7 +29,7 @@ public function testVoltTest()
         $scenario1->step("Step 1")->get('https://www.google.com');
         $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
         $scenario2->step("Step 1")->get('https://www.google.com');
-        $result = $voltTest->run();
+        $result = $voltTest->run(true);
         $this->assertNotEmpty($result->getRawOutput(), "Raw output is empty");
         $this->assertGreaterThan(0, $result->getDuration(), "Duration is not greater than 0");
         $this->assertGreaterThan(0, $result->getAvgResponseTime(), "Average response time is not greater than 0");

From 9fd6f00670e5fb3982a3f72cdc32104e6d3236af Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 17:59:28 +0200
Subject: [PATCH 06/29] add more assertion

---
 tests/VoltTestTest.php | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index 6063d43..40a99db 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -30,8 +30,13 @@ public function testVoltTest()
         $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
         $scenario2->step("Step 1")->get('https://www.google.com');
         $result = $voltTest->run(true);
-        $this->assertNotEmpty($result->getRawOutput(), "Raw output is empty");
-        $this->assertGreaterThan(0, $result->getDuration(), "Duration is not greater than 0");
-        $this->assertGreaterThan(0, $result->getAvgResponseTime(), "Average response time is not greater than 0");
+
+        $this->assertNotEquals('0', $result->getDuration(), "Duration should not be 0");
+        $this->assertNotNull($result->getAvgResponseTime(), "Average response time should not be null");
+
+        $this->assertIsFloat($result->getSuccessRate(), "Success rate should be a float");
+        $this->assertIsInt($result->getTotalRequests(), "Total requests should be an integer");
+        $this->assertIsInt($result->getSuccessRequests(), "Success requests should be an integer");
+        $this->assertIsInt($result->getFailedRequests(), "Failed requests should be an integer");
     }
 }

From 82ea2dbc15d1b21ab411892037b5ac979489c660 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:02:28 +0200
Subject: [PATCH 07/29] dump durations

---
 tests/VoltTestTest.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index 40a99db..2fa59ab 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -30,7 +30,7 @@ public function testVoltTest()
         $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
         $scenario2->step("Step 1")->get('https://www.google.com');
         $result = $voltTest->run(true);
-
+        var_dump($result->getDuration());
         $this->assertNotEquals('0', $result->getDuration(), "Duration should not be 0");
         $this->assertNotNull($result->getAvgResponseTime(), "Average response time should not be null");
 

From 7a10375723e70c24a0385ad8f180d37d0c8b2ae2 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:40:07 +0200
Subject: [PATCH 08/29] trying fix: improve Windows process management and
 stream handling

---
 src/ProcessManager.php | 108 ++++++++++++++++++++++++-----------------
 1 file changed, 64 insertions(+), 44 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 9877eaa..a6be334 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -1,19 +1,21 @@
 <?php
 
 namespace VoltTest;
-
 use RuntimeException;
 
 class ProcessManager
 {
     private string $binaryPath;
-
     private $currentProcess = null;
+    private $isWindows;
 
     public function __construct(string $binaryPath)
     {
         $this->binaryPath = $binaryPath;
-        if (function_exists('pcntl_async_signals')) {
+        $this->isWindows = PHP_OS_FAMILY === 'Windows';
+
+        // Only register signal handlers on non-Windows systems
+        if (!$this->isWindows && function_exists('pcntl_async_signals')) {
             pcntl_async_signals(true);
             pcntl_signal(SIGINT, [$this, 'handleSignal']);
             pcntl_signal(SIGTERM, [$this, 'handleSignal']);
@@ -34,23 +36,15 @@ public function execute(array $config, bool $streamOutput): string
         [$success, $process, $pipes] = $this->openProcess();
         $this->currentProcess = $process;
 
-        if (! $success || ! is_array($pipes)) {
+        if (!$success || !is_array($pipes)) {
             throw new RuntimeException('Failed to start process of volt test');
         }
 
         try {
             $this->writeInput($pipes[0], json_encode($config, JSON_PRETTY_PRINT));
             fclose($pipes[0]);
-
-            $output = $this->handleProcess($pipes, $streamOutput);
-
-            // Store stderr content before closing
-            $stderrContent = '';
-            if (isset($pipes[2]) && is_resource($pipes[2])) {
-                rewind($pipes[2]);
-                $stderrContent = stream_get_contents($pipes[2]);
-            }
-
+            return $this->handleProcess($pipes, $streamOutput);
+        } finally {
             // Clean up pipes
             foreach ($pipes as $pipe) {
                 if (is_resource($pipe)) {
@@ -62,43 +56,38 @@ public function execute(array $config, bool $streamOutput): string
                 $exitCode = $this->closeProcess($process);
                 $this->currentProcess = null;
                 if ($exitCode !== 0) {
-                    echo "\nError: " . trim($stderrContent) . "\n";
-
-                    return '';
-                }
-            }
-
-            return $output;
-        } finally {
-            foreach ($pipes as $pipe) {
-                if (is_resource($pipe)) {
-                    fclose($pipe);
+                    throw new RuntimeException('Process failed with exit code ' . $exitCode);
                 }
             }
-            if (is_resource($process)) {
-                $this->closeProcess($process);
-                $this->currentProcess = null;
-            }
         }
     }
 
     protected function openProcess(): array
     {
-        $pipes = [];
+        $descriptorspec = [
+            0 => ['pipe', 'r'],  // stdin
+            1 => ['pipe', 'w'],  // stdout
+            2 => ['pipe', 'w']   // stderr
+        ];
+
+        // Windows-specific process options
+        $options = $this->isWindows ? [
+            'bypass_shell' => true,
+            'create_process_group' => true  // Important for Windows process management
+        ] : [
+            'bypass_shell' => true
+        ];
+
         $process = proc_open(
             $this->binaryPath,
-            [
-                0 => ['pipe', 'r'],
-                1 => ['pipe', 'w'],
-                2 => ['pipe', 'w'],
-            ],
+            $descriptorspec,
             $pipes,
             null,
             null,
-            ['bypass_shell' => true]
+            $options
         );
 
-        if (! is_resource($process)) {
+        if (!is_resource($process)) {
             return [false, null, []];
         }
 
@@ -108,17 +97,36 @@ protected function openProcess(): array
     private function handleProcess(array $pipes, bool $streamOutput): string
     {
         $output = '';
+        $running = true;
 
-        while (true) {
+        // Set streams to non-blocking mode
+        foreach ($pipes as $pipe) {
+            if (is_resource($pipe)) {
+                stream_set_blocking($pipe, false);
+            }
+        }
+
+        while ($running) {
             $read = array_filter($pipes, 'is_resource');
             if (empty($read)) {
                 break;
             }
 
+            // Windows-specific: Check process status
+            if ($this->isWindows) {
+                $status = proc_get_status($this->currentProcess);
+                if (!$status['running']) {
+                    $running = false;
+                }
+            }
+
             $write = null;
             $except = null;
 
-            if (stream_select($read, $write, $except, 1) === false) {
+            // Use a shorter timeout on Windows
+            $timeout = $this->isWindows ? 0.1 : 1;
+
+            if (stream_select($read, $write, $except, 0, $timeout * 1000000) === false) {
                 break;
             }
 
@@ -130,7 +138,6 @@ private function handleProcess(array $pipes, bool $streamOutput): string
                     if (feof($pipe)) {
                         fclose($pipe);
                         unset($pipes[$type]);
-
                         continue;
                     }
                 }
@@ -139,9 +146,15 @@ private function handleProcess(array $pipes, bool $streamOutput): string
                     $output .= $data;
                     if ($streamOutput) {
                         echo $data;
+                        if ($this->isWindows) {
+                            flush(); // Ensure output is displayed immediately on Windows
+                        }
                     }
                 } elseif ($type === 2 && $streamOutput) { // stderr
                     fwrite(STDERR, $data);
+                    if ($this->isWindows) {
+                        flush();
+                    }
                 }
             }
         }
@@ -153,21 +166,28 @@ protected function writeInput($pipe, string $input): void
     {
         if (is_resource($pipe)) {
             fwrite($pipe, $input);
+            if ($this->isWindows) {
+                fflush($pipe); // Ensure data is written immediately on Windows
+            }
         }
     }
 
     protected function closeProcess($process): int
     {
-        if (! is_resource($process)) {
+        if (!is_resource($process)) {
             return -1;
         }
 
         $status = proc_get_status($process);
         if ($status['running']) {
-            proc_terminate($process);
+            // Windows-specific process termination
+            if ($this->isWindows) {
+                exec('taskkill /F /T /PID ' . $status['pid']);
+            } else {
+                proc_terminate($process);
+            }
         }
 
-
         return proc_close($process);
     }
-}
+}
\ No newline at end of file

From 4d600d0524934c694adae60a4009ed49bc3f8b17 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:46:49 +0200
Subject: [PATCH 09/29] deubgging windows proccess

---
 src/ProcessManager.php | 241 ++++++++++++++++++-----------------------
 1 file changed, 103 insertions(+), 138 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index a6be334..69cdf56 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -7,187 +7,152 @@ class ProcessManager
 {
     private string $binaryPath;
     private $currentProcess = null;
-    private $isWindows;
+    private bool $debug;
 
-    public function __construct(string $binaryPath)
+    public function __construct(string $binaryPath, bool $debug = true)
     {
         $this->binaryPath = $binaryPath;
-        $this->isWindows = PHP_OS_FAMILY === 'Windows';
-
-        // Only register signal handlers on non-Windows systems
-        if (!$this->isWindows && function_exists('pcntl_async_signals')) {
-            pcntl_async_signals(true);
-            pcntl_signal(SIGINT, [$this, 'handleSignal']);
-            pcntl_signal(SIGTERM, [$this, 'handleSignal']);
-        }
+        $this->debug = $debug;
+        $this->debugLog("ProcessManager initialized with binary: $binaryPath");
     }
 
-    private function handleSignal(int $signal): void
+    private function debugLog(string $message): void
     {
-        if ($this->currentProcess && is_resource($this->currentProcess)) {
-            proc_terminate($this->currentProcess);
-            proc_close($this->currentProcess);
+        if ($this->debug) {
+            echo "[DEBUG] " . date('Y-m-d H:i:s') . " - $message\n";
+            flush();
         }
-        exit(0);
     }
 
     public function execute(array $config, bool $streamOutput): string
     {
-        [$success, $process, $pipes] = $this->openProcess();
-        $this->currentProcess = $process;
+        $this->debugLog("Starting execution");
 
-        if (!$success || !is_array($pipes)) {
-            throw new RuntimeException('Failed to start process of volt test');
-        }
+        // For Windows, ensure the path is properly quoted
+        $cmd = PHP_OS_FAMILY === 'Windows'
+            ? '"' . str_replace('/', '\\', $this->binaryPath) . '"'
+            : $this->binaryPath;
 
-        try {
-            $this->writeInput($pipes[0], json_encode($config, JSON_PRETTY_PRINT));
-            fclose($pipes[0]);
-            return $this->handleProcess($pipes, $streamOutput);
-        } finally {
-            // Clean up pipes
-            foreach ($pipes as $pipe) {
-                if (is_resource($pipe)) {
-                    fclose($pipe);
-                }
-            }
+        $this->debugLog("Command to execute: $cmd");
 
-            if (is_resource($process)) {
-                $exitCode = $this->closeProcess($process);
-                $this->currentProcess = null;
-                if ($exitCode !== 0) {
-                    throw new RuntimeException('Process failed with exit code ' . $exitCode);
-                }
-            }
-        }
-    }
+        // Create temporary file for input
+        $tmpfname = tempnam(sys_get_temp_dir(), 'volt_');
+        $this->debugLog("Created temporary file: $tmpfname");
+
+        file_put_contents($tmpfname, json_encode($config, JSON_PRETTY_PRINT));
+        $this->debugLog("Written config to temporary file");
 
-    protected function openProcess(): array
-    {
         $descriptorspec = [
-            0 => ['pipe', 'r'],  // stdin
-            1 => ['pipe', 'w'],  // stdout
-            2 => ['pipe', 'w']   // stderr
+            0 => ['pipe', 'r'],
+            1 => ['pipe', 'w'],
+            2 => ['pipe', 'w']
         ];
 
-        // Windows-specific process options
-        $options = $this->isWindows ? [
-            'bypass_shell' => true,
-            'create_process_group' => true  // Important for Windows process management
-        ] : [
-            'bypass_shell' => true
-        ];
+        $this->debugLog("Opening process");
 
-        $process = proc_open(
-            $this->binaryPath,
-            $descriptorspec,
-            $pipes,
-            null,
-            null,
-            $options
-        );
+        $process = proc_open($cmd, $descriptorspec, $pipes, null, null, [
+            'bypass_shell' => true,
+            'create_process_group' => true
+        ]);
 
         if (!is_resource($process)) {
-            return [false, null, []];
+            unlink($tmpfname);
+            throw new RuntimeException('Failed to start process');
         }
 
-        return [true, $process, $pipes];
-    }
+        $this->currentProcess = $process;
+        $this->debugLog("Process started successfully");
 
-    private function handleProcess(array $pipes, bool $streamOutput): string
-    {
-        $output = '';
-        $running = true;
+        try {
+            // Write config to stdin
+            $this->debugLog("Writing config to process");
+            fwrite($pipes[0], file_get_contents($tmpfname));
+            fclose($pipes[0]);
+            unlink($tmpfname);
 
-        // Set streams to non-blocking mode
-        foreach ($pipes as $pipe) {
-            if (is_resource($pipe)) {
-                stream_set_blocking($pipe, false);
-            }
-        }
+            $this->debugLog("Starting to read output");
+            $output = '';
 
-        while ($running) {
-            $read = array_filter($pipes, 'is_resource');
-            if (empty($read)) {
-                break;
-            }
+            // Set streams to non-blocking
+            stream_set_blocking($pipes[1], false);
+            stream_set_blocking($pipes[2], false);
+
+            while (true) {
+                $status = proc_get_status($process);
 
-            // Windows-specific: Check process status
-            if ($this->isWindows) {
-                $status = proc_get_status($this->currentProcess);
                 if (!$status['running']) {
-                    $running = false;
+                    $this->debugLog("Process has finished running");
+                    break;
                 }
-            }
-
-            $write = null;
-            $except = null;
 
-            // Use a shorter timeout on Windows
-            $timeout = $this->isWindows ? 0.1 : 1;
+                $read = [$pipes[1], $pipes[2]];
+                $write = null;
+                $except = null;
 
-            if (stream_select($read, $write, $except, 0, $timeout * 1000000) === false) {
-                break;
-            }
-
-            foreach ($read as $pipe) {
-                $type = array_search($pipe, $pipes, true);
-                $data = fread($pipe, 4096);
+                if (stream_select($read, $write, $except, 0, 100000)) {
+                    foreach ($read as $pipe) {
+                        $data = fread($pipe, 4096);
+                        if ($data === false || $data === '') {
+                            continue;
+                        }
 
-                if ($data === false || $data === '') {
-                    if (feof($pipe)) {
-                        fclose($pipe);
-                        unset($pipes[$type]);
-                        continue;
+                        if ($pipe === $pipes[1]) {
+                            $output .= $data;
+                            if ($streamOutput) {
+                                echo $data;
+                                flush();
+                            }
+                        } else {
+                            fwrite(STDERR, $data);
+                            flush();
+                        }
                     }
                 }
+            }
 
-                if ($type === 1) { // stdout
-                    $output .= $data;
-                    if ($streamOutput) {
-                        echo $data;
-                        if ($this->isWindows) {
-                            flush(); // Ensure output is displayed immediately on Windows
-                        }
-                    }
-                } elseif ($type === 2 && $streamOutput) { // stderr
-                    fwrite(STDERR, $data);
-                    if ($this->isWindows) {
-                        flush();
-                    }
+            $this->debugLog("Finished reading output");
+
+            // Close remaining pipes
+            foreach ($pipes as $pipe) {
+                if (is_resource($pipe)) {
+                    fclose($pipe);
                 }
             }
-        }
 
-        return $output;
-    }
+            // Get exit code
+            $exitCode = proc_close($process);
+            $this->debugLog("Process closed with exit code: $exitCode");
 
-    protected function writeInput($pipe, string $input): void
-    {
-        if (is_resource($pipe)) {
-            fwrite($pipe, $input);
-            if ($this->isWindows) {
-                fflush($pipe); // Ensure data is written immediately on Windows
+            if ($exitCode !== 0) {
+                throw new RuntimeException("Process failed with exit code $exitCode");
             }
-        }
-    }
 
-    protected function closeProcess($process): int
-    {
-        if (!is_resource($process)) {
-            return -1;
-        }
+            return $output;
+
+        } catch (\Exception $e) {
+            $this->debugLog("Error occurred: " . $e->getMessage());
+
+            // Clean up
+            foreach ($pipes as $pipe) {
+                if (is_resource($pipe)) {
+                    fclose($pipe);
+                }
+            }
 
-        $status = proc_get_status($process);
-        if ($status['running']) {
-            // Windows-specific process termination
-            if ($this->isWindows) {
-                exec('taskkill /F /T /PID ' . $status['pid']);
-            } else {
-                proc_terminate($process);
+            if (is_resource($process)) {
+                $status = proc_get_status($process);
+                if ($status['running']) {
+                    // Force kill on Windows
+                    if (PHP_OS_FAMILY === 'Windows') {
+                        exec('taskkill /F /T /PID ' . $status['pid']);
+                    } else {
+                        proc_terminate($process);
+                    }
+                }
+                proc_close($process);
             }
-        }
 
-        return proc_close($process);
+            throw $e;
+        }
     }
 }
\ No newline at end of file

From ce1234f4606c1115e616571238db7bb40886dfbd Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:53:50 +0200
Subject: [PATCH 10/29] WIP

---
 src/ProcessManager.php | 90 +++++++++++++++++++++++++-----------------
 1 file changed, 53 insertions(+), 37 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 69cdf56..d6c2515 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -11,15 +11,26 @@ class ProcessManager
 
     public function __construct(string $binaryPath, bool $debug = true)
     {
-        $this->binaryPath = $binaryPath;
+        // Normalize path for Windows
+        $this->binaryPath = str_replace('/', '\\', $binaryPath);
         $this->debug = $debug;
-        $this->debugLog("ProcessManager initialized with binary: $binaryPath");
+
+        // Verify binary exists and is executable
+        if (!file_exists($this->binaryPath)) {
+            throw new RuntimeException("Binary not found at: {$this->binaryPath}");
+        }
+
+        if (!is_executable($this->binaryPath)) {
+            throw new RuntimeException("Binary is not executable: {$this->binaryPath}");
+        }
+
+        $this->debugLog("ProcessManager initialized with verified binary: {$this->binaryPath}");
     }
 
     private function debugLog(string $message): void
     {
         if ($this->debug) {
-            echo "[DEBUG] " . date('Y-m-d H:i:s') . " - $message\n";
+            fwrite(STDERR, "[DEBUG] " . date('Y-m-d H:i:s') . " - $message\n");
             flush();
         }
     }
@@ -28,70 +39,75 @@ public function execute(array $config, bool $streamOutput): string
     {
         $this->debugLog("Starting execution");
 
-        // For Windows, ensure the path is properly quoted
-        $cmd = PHP_OS_FAMILY === 'Windows'
-            ? '"' . str_replace('/', '\\', $this->binaryPath) . '"'
-            : $this->binaryPath;
-
-        $this->debugLog("Command to execute: $cmd");
-
         // Create temporary file for input
         $tmpfname = tempnam(sys_get_temp_dir(), 'volt_');
         $this->debugLog("Created temporary file: $tmpfname");
 
+        // Write config to temp file
         file_put_contents($tmpfname, json_encode($config, JSON_PRETTY_PRINT));
-        $this->debugLog("Written config to temporary file");
 
+        // Build command with proper escaping
+        $cmd = escapeshellarg($this->binaryPath);
+        $this->debugLog("Executing command: $cmd");
+
+        // Setup process
         $descriptorspec = [
-            0 => ['pipe', 'r'],
-            1 => ['pipe', 'w'],
-            2 => ['pipe', 'w']
+            0 => ['pipe', 'r'],  // stdin
+            1 => ['pipe', 'w'],  // stdout
+            2 => ['pipe', 'w']   // stderr
         ];
 
-        $this->debugLog("Opening process");
+        $cwd = dirname($this->binaryPath);
+        $env = ['VOLT_TEST_DEBUG' => '1'];
 
-        $process = proc_open($cmd, $descriptorspec, $pipes, null, null, [
+        $this->debugLog("Opening process in directory: $cwd");
+
+        $process = proc_open($cmd, $descriptorspec, $pipes, $cwd, $env, [
             'bypass_shell' => true,
             'create_process_group' => true
         ]);
 
         if (!is_resource($process)) {
             unlink($tmpfname);
-            throw new RuntimeException('Failed to start process');
+            throw new RuntimeException("Failed to start process: $cmd");
         }
 
         $this->currentProcess = $process;
         $this->debugLog("Process started successfully");
 
         try {
-            // Write config to stdin
+            // Write config to process
             $this->debugLog("Writing config to process");
-            fwrite($pipes[0], file_get_contents($tmpfname));
+            $configContent = file_get_contents($tmpfname);
+            fwrite($pipes[0], $configContent);
             fclose($pipes[0]);
             unlink($tmpfname);
 
-            $this->debugLog("Starting to read output");
-            $output = '';
-
-            // Set streams to non-blocking
+            // Set up non-blocking reads
             stream_set_blocking($pipes[1], false);
             stream_set_blocking($pipes[2], false);
 
-            while (true) {
+            $output = '';
+            $processRunning = true;
+
+            $this->debugLog("Starting output reading loop");
+
+            while ($processRunning) {
                 $status = proc_get_status($process);
+                $processRunning = $status['running'];
 
-                if (!$status['running']) {
-                    $this->debugLog("Process has finished running");
+                $read = array_filter([$pipes[1], $pipes[2]], 'is_resource');
+                if (empty($read)) {
                     break;
                 }
 
-                $read = [$pipes[1], $pipes[2]];
                 $write = null;
                 $except = null;
 
                 if (stream_select($read, $write, $except, 0, 100000)) {
                     foreach ($read as $pipe) {
                         $data = fread($pipe, 4096);
+
                         if ($data === false || $data === '') {
                             continue;
                         }
@@ -99,7 +115,7 @@ public function execute(array $config, bool $streamOutput): string
                         if ($pipe === $pipes[1]) {
                             $output .= $data;
                             if ($streamOutput) {
-                                echo $data;
+                                fwrite(STDOUT, $data);
                                 flush();
                             }
                         } else {
@@ -108,9 +124,13 @@ public function execute(array $config, bool $streamOutput): string
                         }
                     }
                 }
-            }
 
-            $this->debugLog("Finished reading output");
+                // Check if process has exited
+                if (!$processRunning) {
+                    $this->debugLog("Process has finished");
+                    break;
+                }
+            }
 
             // Close remaining pipes
             foreach ($pipes as $pipe) {
@@ -119,7 +139,7 @@ public function execute(array $config, bool $streamOutput): string
                 }
             }
 
-            // Get exit code
+            // Get exit code and close process
             $exitCode = proc_close($process);
             $this->debugLog("Process closed with exit code: $exitCode");
 
@@ -142,12 +162,8 @@ public function execute(array $config, bool $streamOutput): string
             if (is_resource($process)) {
                 $status = proc_get_status($process);
                 if ($status['running']) {
-                    // Force kill on Windows
-                    if (PHP_OS_FAMILY === 'Windows') {
-                        exec('taskkill /F /T /PID ' . $status['pid']);
-                    } else {
-                        proc_terminate($process);
-                    }
+                    exec("taskkill /F /T /PID {$status['pid']} 2>&1", $output, $resultCode);
+                    $this->debugLog("Taskkill result: " . implode("\n", $output) . " (code: $resultCode)");
                 }
                 proc_close($process);
             }

From 7db72f630992e0669931e6140cad9018111e7200 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:56:57 +0200
Subject: [PATCH 11/29] WIP

---
 src/ProcessManager.php | 140 ++++++++++++++++++++---------------------
 1 file changed, 70 insertions(+), 70 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index d6c2515..97f4c85 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -8,23 +8,18 @@ class ProcessManager
     private string $binaryPath;
     private $currentProcess = null;
     private bool $debug;
+    private int $timeout = 30; // timeout in seconds
 
-    public function __construct(string $binaryPath, bool $debug = true)
+    public function __construct(string $binaryPath, bool $debug = false)
     {
-        // Normalize path for Windows
         $this->binaryPath = str_replace('/', '\\', $binaryPath);
         $this->debug = $debug;
 
-        // Verify binary exists and is executable
         if (!file_exists($this->binaryPath)) {
             throw new RuntimeException("Binary not found at: {$this->binaryPath}");
         }
 
-        if (!is_executable($this->binaryPath)) {
-            throw new RuntimeException("Binary is not executable: {$this->binaryPath}");
-        }
-
-        $this->debugLog("ProcessManager initialized with verified binary: {$this->binaryPath}");
+        $this->debugLog("ProcessManager initialized with binary: {$this->binaryPath}");
     }
 
     private function debugLog(string $message): void
@@ -39,107 +34,110 @@ public function execute(array $config, bool $streamOutput): string
     {
         $this->debugLog("Starting execution");
 
-        // Create temporary file for input
-        $tmpfname = tempnam(sys_get_temp_dir(), 'volt_');
-        $this->debugLog("Created temporary file: $tmpfname");
-
-        // Write config to temp file
-        file_put_contents($tmpfname, json_encode($config, JSON_PRETTY_PRINT));
-
-        // Build command with proper escaping
+        // Prepare command
         $cmd = escapeshellarg($this->binaryPath);
-        $this->debugLog("Executing command: $cmd");
+        $this->debugLog("Command: $cmd");
 
-        // Setup process
+        // Prepare config
+        $configJson = json_encode($config, JSON_PRETTY_PRINT);
+        $this->debugLog("Config prepared: " . substr($configJson, 0, 100) . "...");
+
+        // Start process
         $descriptorspec = [
-            0 => ['pipe', 'r'],  // stdin
-            1 => ['pipe', 'w'],  // stdout
-            2 => ['pipe', 'w']   // stderr
+            0 => ['pipe', 'r'],
+            1 => ['pipe', 'w'],
+            2 => ['pipe', 'w']
         ];
 
-        $cwd = dirname($this->binaryPath);
-        $env = ['VOLT_TEST_DEBUG' => '1'];
-
-        $this->debugLog("Opening process in directory: $cwd");
-
-        $process = proc_open($cmd, $descriptorspec, $pipes, $cwd, $env, [
+        $this->debugLog("Opening process");
+        $process = proc_open($cmd, $descriptorspec, $pipes, null, null, [
             'bypass_shell' => true,
             'create_process_group' => true
         ]);
 
         if (!is_resource($process)) {
-            unlink($tmpfname);
-            throw new RuntimeException("Failed to start process: $cmd");
+            throw new RuntimeException("Failed to start process");
         }
 
         $this->currentProcess = $process;
-        $this->debugLog("Process started successfully");
+        $this->debugLog("Process started");
+
+        // Set streams to non-blocking mode
+        foreach ($pipes as $pipe) {
+            stream_set_blocking($pipe, false);
+        }
 
         try {
-            // Write config to process
+            // Write config to stdin
             $this->debugLog("Writing config to process");
-            $configContent = file_get_contents($tmpfname);
-            fwrite($pipes[0], $configContent);
-            fclose($pipes[0]);
-            unlink($tmpfname);
+            $written = fwrite($pipes[0], $configJson);
+            if ($written === false) {
+                throw new RuntimeException("Failed to write config to process");
+            }
+            $this->debugLog("Wrote $written bytes to process");
 
-            // Set up non-blocking reads
-            stream_set_blocking($pipes[1], false);
-            stream_set_blocking($pipes[2], false);
+            // Important: flush and close stdin
+            fflush($pipes[0]);
+            fclose($pipes[0]);
+            $this->debugLog("Closed stdin pipe");
 
             $output = '';
-            $processRunning = true;
-
-            $this->debugLog("Starting output reading loop");
+            $startTime = time();
+            $lastDataTime = time();
 
-            while ($processRunning) {
+            while (true) {
                 $status = proc_get_status($process);
-                $processRunning = $status['running'];
-
-                $read = array_filter([$pipes[1], $pipes[2]], 'is_resource');
-                if (empty($read)) {
+                if (!$status['running']) {
+                    $this->debugLog("Process has finished");
                     break;
                 }
 
+                // Check timeout
+                if (time() - $startTime > $this->timeout) {
+                    throw new RuntimeException("Process timed out after {$this->timeout} seconds");
+                }
+
+                // Check for data timeout (no data received)
+                if (time() - $lastDataTime > 5) {
+                    $this->debugLog("No data received for 5 seconds, checking process status");
+                    $lastDataTime = time(); // Reset timer
+                }
+
+                $read = [$pipes[1], $pipes[2]];
                 $write = null;
                 $except = null;
 
-                if (stream_select($read, $write, $except, 0, 100000)) {
+                // Short timeout for select
+                if (stream_select($read, $write, $except, 0, 200000)) {
                     foreach ($read as $pipe) {
-                        $data = fread($pipe, 4096);
-
-                        if ($data === false || $data === '') {
+                        $data = fread($pipe, 8192);
+                        if ($data === false) {
                             continue;
                         }
-
-                        if ($pipe === $pipes[1]) {
-                            $output .= $data;
-                            if ($streamOutput) {
-                                fwrite(STDOUT, $data);
+                        if ($data !== '') {
+                            $lastDataTime = time();
+                            if ($pipe === $pipes[1]) {
+                                $output .= $data;
+                                if ($streamOutput) {
+                                    fwrite(STDOUT, $data);
+                                    flush();
+                                }
+                            } else {
+                                fwrite(STDERR, $data);
                                 flush();
                             }
-                        } else {
-                            fwrite(STDERR, $data);
-                            flush();
                         }
                     }
                 }
-
-                // Check if process has exited
-                if (!$processRunning) {
-                    $this->debugLog("Process has finished");
-                    break;
-                }
             }
 
             // Close remaining pipes
-            foreach ($pipes as $pipe) {
-                if (is_resource($pipe)) {
-                    fclose($pipe);
+            foreach ([1, 2] as $i) {
+                if (isset($pipes[$i]) && is_resource($pipes[$i])) {
+                    fclose($pipes[$i]);
                 }
             }
 
-            // Get exit code and close process
             $exitCode = proc_close($process);
             $this->debugLog("Process closed with exit code: $exitCode");
 
@@ -152,18 +150,20 @@ public function execute(array $config, bool $streamOutput): string
         } catch (\Exception $e) {
             $this->debugLog("Error occurred: " . $e->getMessage());
 
-            // Clean up
+            // Clean up pipes
             foreach ($pipes as $pipe) {
                 if (is_resource($pipe)) {
                     fclose($pipe);
                 }
             }
 
+            // Terminate process if still running
             if (is_resource($process)) {
                 $status = proc_get_status($process);
                 if ($status['running']) {
+                    // Force kill on Windows
                     exec("taskkill /F /T /PID {$status['pid']} 2>&1", $output, $resultCode);
-                    $this->debugLog("Taskkill result: " . implode("\n", $output) . " (code: $resultCode)");
+                    $this->debugLog("Taskkill result code: $resultCode");
                 }
                 proc_close($process);
             }

From e4ca6a4ea6a174636387b6d813ba3c3939232fe0 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 18:58:23 +0200
Subject: [PATCH 12/29] WIP

---
 src/ProcessManager.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 97f4c85..7875ec4 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -10,7 +10,7 @@ class ProcessManager
     private bool $debug;
     private int $timeout = 30; // timeout in seconds
 
-    public function __construct(string $binaryPath, bool $debug = false)
+    public function __construct(string $binaryPath, bool $debug = true)
     {
         $this->binaryPath = str_replace('/', '\\', $binaryPath);
         $this->debug = $debug;

From 88d22e6ac57e1853696edd9317d97df8d0f2b483 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:00:55 +0200
Subject: [PATCH 13/29] WIP

---
 src/ProcessManager.php | 86 +++++++++++++++++++++---------------------
 1 file changed, 44 insertions(+), 42 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 7875ec4..3734c52 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -8,7 +8,7 @@ class ProcessManager
     private string $binaryPath;
     private $currentProcess = null;
     private bool $debug;
-    private int $timeout = 30; // timeout in seconds
+    private int $timeout = 30;
 
     public function __construct(string $binaryPath, bool $debug = true)
     {
@@ -34,52 +34,46 @@ public function execute(array $config, bool $streamOutput): string
     {
         $this->debugLog("Starting execution");
 
-        // Prepare command
-        $cmd = escapeshellarg($this->binaryPath);
-        $this->debugLog("Command: $cmd");
+        // Create temporary config file
+        $configFile = tempnam(sys_get_temp_dir(), 'volt_config_');
+        $this->debugLog("Created config file: $configFile");
+
+        // Write config to file
+        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
+        $this->debugLog("Wrote config to file");
 
-        // Prepare config
-        $configJson = json_encode($config, JSON_PRETTY_PRINT);
-        $this->debugLog("Config prepared: " . substr($configJson, 0, 100) . "...");
+        // Prepare command with config file argument
+        $cmd = sprintf(
+            '"%s" --config "%s"',
+            $this->binaryPath,
+            $configFile
+        );
+        $this->debugLog("Command: $cmd");
 
         // Start process
         $descriptorspec = [
-            0 => ['pipe', 'r'],
-            1 => ['pipe', 'w'],
-            2 => ['pipe', 'w']
+            1 => ['pipe', 'w'],  // stdout
+            2 => ['pipe', 'w']   // stderr
         ];
 
         $this->debugLog("Opening process");
         $process = proc_open($cmd, $descriptorspec, $pipes, null, null, [
-            'bypass_shell' => true,
-            'create_process_group' => true
+            'bypass_shell' => false  // Changed to false for Windows command
         ]);
 
         if (!is_resource($process)) {
+            unlink($configFile);
             throw new RuntimeException("Failed to start process");
         }
 
         $this->currentProcess = $process;
         $this->debugLog("Process started");
 
-        // Set streams to non-blocking mode
-        foreach ($pipes as $pipe) {
-            stream_set_blocking($pipe, false);
-        }
-
         try {
-            // Write config to stdin
-            $this->debugLog("Writing config to process");
-            $written = fwrite($pipes[0], $configJson);
-            if ($written === false) {
-                throw new RuntimeException("Failed to write config to process");
+            // Set streams to non-blocking mode
+            foreach ($pipes as $pipe) {
+                stream_set_blocking($pipe, false);
             }
-            $this->debugLog("Wrote $written bytes to process");
-
-            // Important: flush and close stdin
-            fflush($pipes[0]);
-            fclose($pipes[0]);
-            $this->debugLog("Closed stdin pipe");
 
             $output = '';
             $startTime = time();
@@ -97,17 +91,16 @@ public function execute(array $config, bool $streamOutput): string
                     throw new RuntimeException("Process timed out after {$this->timeout} seconds");
                 }
 
-                // Check for data timeout (no data received)
+                // Check for data timeout
                 if (time() - $lastDataTime > 5) {
-                    $this->debugLog("No data received for 5 seconds, checking process status");
-                    $lastDataTime = time(); // Reset timer
+                    $this->debugLog("No data received for 5 seconds, checking process");
+                    $lastDataTime = time();
                 }
 
-                $read = [$pipes[1], $pipes[2]];
+                $read = $pipes;
                 $write = null;
                 $except = null;
 
-                // Short timeout for select
                 if (stream_select($read, $write, $except, 0, 200000)) {
                     foreach ($read as $pipe) {
                         $data = fread($pipe, 8192);
@@ -131,16 +124,22 @@ public function execute(array $config, bool $streamOutput): string
                 }
             }
 
-            // Close remaining pipes
-            foreach ([1, 2] as $i) {
-                if (isset($pipes[$i]) && is_resource($pipes[$i])) {
-                    fclose($pipes[$i]);
+            // Close pipes
+            foreach ($pipes as $pipe) {
+                if (is_resource($pipe)) {
+                    fclose($pipe);
                 }
             }
 
             $exitCode = proc_close($process);
             $this->debugLog("Process closed with exit code: $exitCode");
 
+            // Clean up config file
+            if (file_exists($configFile)) {
+                unlink($configFile);
+                $this->debugLog("Cleaned up config file");
+            }
+
             if ($exitCode !== 0) {
                 throw new RuntimeException("Process failed with exit code $exitCode");
             }
@@ -150,25 +149,28 @@ public function execute(array $config, bool $streamOutput): string
         } catch (\Exception $e) {
             $this->debugLog("Error occurred: " . $e->getMessage());
 
-            // Clean up pipes
+            // Clean up
             foreach ($pipes as $pipe) {
                 if (is_resource($pipe)) {
                     fclose($pipe);
                 }
             }
 
-            // Terminate process if still running
             if (is_resource($process)) {
                 $status = proc_get_status($process);
                 if ($status['running']) {
-                    // Force kill on Windows
-                    exec("taskkill /F /T /PID {$status['pid']} 2>&1", $output, $resultCode);
+                    exec("taskkill /F /T /PID {$status['pid']} 2>&1", $killOutput, $resultCode);
                     $this->debugLog("Taskkill result code: $resultCode");
                 }
                 proc_close($process);
             }
 
+            // Clean up config file
+            if (file_exists($configFile)) {
+                unlink($configFile);
+            }
+
             throw $e;
         }
     }
-}
\ No newline at end of file
+}

From 77baf127c4f657b1425756284aa4ea3c76f9ab7f Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:03:49 +0200
Subject: [PATCH 14/29] WIP

---
 src/ProcessManager.php | 71 +++++++++++++++++++++++-------------------
 1 file changed, 39 insertions(+), 32 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 3734c52..3feef9a 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -34,20 +34,22 @@ public function execute(array $config, bool $streamOutput): string
     {
         $this->debugLog("Starting execution");
 
-        // Create temporary config file
-        $configFile = tempnam(sys_get_temp_dir(), 'volt_config_');
-        $this->debugLog("Created config file: $configFile");
+        // Create temporary directory for test files
+        $tempDir = rtrim(sys_get_temp_dir(), '/\\') . '\\volt_' . uniqid();
+        mkdir($tempDir);
+        $this->debugLog("Created temp directory: $tempDir");
 
-        // Write config to file
+        // Create config file
+        $configFile = $tempDir . '\\config.json';
         file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
-        $this->debugLog("Wrote config to file");
-
-        // Prepare command with config file argument
-        $cmd = sprintf(
-            '"%s" --config "%s"',
-            $this->binaryPath,
-            $configFile
-        );
+        $this->debugLog("Wrote config to file: $configFile");
+
+        // Change to temp directory and prepare command
+        $currentDir = getcwd();
+        chdir($tempDir);
+
+        // Prepare command without any flags - the binary should read config.json by default
+        $cmd = sprintf('"%s"', $this->binaryPath);
         $this->debugLog("Command: $cmd");
 
         // Start process
@@ -56,13 +58,13 @@ public function execute(array $config, bool $streamOutput): string
             2 => ['pipe', 'w']   // stderr
         ];
 
-        $this->debugLog("Opening process");
-        $process = proc_open($cmd, $descriptorspec, $pipes, null, null, [
-            'bypass_shell' => false  // Changed to false for Windows command
+        $this->debugLog("Opening process in directory: " . getcwd());
+        $process = proc_open($cmd, $descriptorspec, $pipes, $tempDir, null, [
+            'bypass_shell' => false
         ]);
 
         if (!is_resource($process)) {
-            unlink($configFile);
+            $this->cleanup($tempDir, $currentDir);
             throw new RuntimeException("Failed to start process");
         }
 
@@ -91,12 +93,6 @@ public function execute(array $config, bool $streamOutput): string
                     throw new RuntimeException("Process timed out after {$this->timeout} seconds");
                 }
 
-                // Check for data timeout
-                if (time() - $lastDataTime > 5) {
-                    $this->debugLog("No data received for 5 seconds, checking process");
-                    $lastDataTime = time();
-                }
-
                 $read = $pipes;
                 $write = null;
                 $except = null;
@@ -134,11 +130,8 @@ public function execute(array $config, bool $streamOutput): string
             $exitCode = proc_close($process);
             $this->debugLog("Process closed with exit code: $exitCode");
 
-            // Clean up config file
-            if (file_exists($configFile)) {
-                unlink($configFile);
-                $this->debugLog("Cleaned up config file");
-            }
+            // Restore original directory and cleanup
+            $this->cleanup($tempDir, $currentDir);
 
             if ($exitCode !== 0) {
                 throw new RuntimeException("Process failed with exit code $exitCode");
@@ -165,12 +158,26 @@ public function execute(array $config, bool $streamOutput): string
                 proc_close($process);
             }
 
-            // Clean up config file
-            if (file_exists($configFile)) {
-                unlink($configFile);
-            }
+            // Restore directory and cleanup
+            $this->cleanup($tempDir, $currentDir);
 
             throw $e;
         }
     }
-}
+
+    private function cleanup(string $tempDir, string $currentDir): void
+    {
+        // Restore original directory
+        chdir($currentDir);
+
+        // Clean up temp directory
+        if (file_exists($tempDir)) {
+            $files = glob($tempDir . '/*');
+            foreach ($files as $file) {
+                unlink($file);
+            }
+            rmdir($tempDir);
+            $this->debugLog("Cleaned up temp directory");
+        }
+    }
+}
\ No newline at end of file

From 4fd937c1c672f31997e2449036ef620c83be90ee Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:08:09 +0200
Subject: [PATCH 15/29] WIP

---
 src/ProcessManager.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 3feef9a..fbab8fc 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -44,6 +44,8 @@ public function execute(array $config, bool $streamOutput): string
         file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
         $this->debugLog("Wrote config to file: $configFile");
 
+        $this->debugLog("config file contain: " . file_get_contents($configFile));
+
         // Change to temp directory and prepare command
         $currentDir = getcwd();
         chdir($tempDir);

From 9cc45accf4c2160cf24f592db59dae1817e6e321 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:14:50 +0200
Subject: [PATCH 16/29] binary test

---
 tests/BinaryTest.php | 152 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 152 insertions(+)
 create mode 100644 tests/BinaryTest.php

diff --git a/tests/BinaryTest.php b/tests/BinaryTest.php
new file mode 100644
index 0000000..7168a76
--- /dev/null
+++ b/tests/BinaryTest.php
@@ -0,0 +1,152 @@
+<?php
+
+namespace Tests;
+
+use PHPUnit\Framework\TestCase;
+use VoltTest\Platform;
+
+Class BinaryTest extends TestCase
+{
+    private string $binaryPath;
+
+    protected function setUp(): void
+    {
+        $this->binaryPath = Platform::getBinaryPath();
+        $this->assertTrue(file_exists($this->binaryPath), "Binary does not exist at: {$this->binaryPath}");
+        $this->assertTrue(is_executable($this->binaryPath), "Binary is not executable");
+    }
+
+    private function runCommand(string $cmd): array
+    {
+        $output = [];
+        $returnVar = -1;
+        exec($cmd . " 2>&1", $output, $returnVar);
+        return ['output' => $output, 'code' => $returnVar];
+    }
+
+    public function testBinaryBasicExecution(): void
+    {
+        $result = $this->runCommand(escapeshellarg($this->binaryPath));
+        $this->assertNotEmpty($result['output'], "Binary should produce some output");
+    }
+
+    public function testBinaryHelp(): void
+    {
+        $result = $this->runCommand(escapeshellarg($this->binaryPath) . " -h");
+        $this->assertNotEmpty($result['output'], "Help command should produce output");
+        $this->assertStringContainsString("Usage", implode("\n", $result['output']), "Help output should contain usage information");
+    }
+
+    public function testBinaryVersion(): void
+    {
+        $result = $this->runCommand(escapeshellarg($this->binaryPath) . " -v");
+        $this->assertNotEmpty($result['output'], "Version command should produce output");
+    }
+
+    public function testBinaryWithConfig(): void
+    {
+        // Create test configuration
+        $config = [
+            'name' => 'test',
+            'description' => 'test',
+            'virtual_users' => 1,
+            'duration' => '5s',
+            'target' => [
+                'url' => 'http://example.com',
+                'idle_timeout' => '30s'
+            ],
+            'scenarios' => [[
+                'name' => 'test',
+                'steps' => [[
+                    'name' => 'test',
+                    'request' => [
+                        'method' => 'GET',
+                        'url' => 'http://example.com'
+                    ]
+                ]]
+            ]]
+        ];
+
+        // Create temporary config file
+        $configFile = tempnam(sys_get_temp_dir(), 'volt_test_');
+        $this->assertNotFalse($configFile, "Failed to create temporary config file");
+
+        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
+
+        try {
+            // Test different ways of passing config
+            $testCommands = [
+                'standard' => escapeshellarg($this->binaryPath) . " -config " . escapeshellarg($configFile),
+                'short' => escapeshellarg($this->binaryPath) . " -f " . escapeshellarg($configFile),
+                'input' => escapeshellarg($this->binaryPath) . " -input " . escapeshellarg($configFile),
+                'stdin' => "type " . escapeshellarg($configFile) . " | " . escapeshellarg($this->binaryPath)
+            ];
+
+            foreach ($testCommands as $type => $cmd) {
+                $result = $this->runCommand($cmd);
+                $output = implode("\n", $result['output']);
+
+                $this->assertNotEmpty($output, "Command $type should produce output");
+                $this->assertStringNotContainsString("panic:", $output, "Command $type should not panic");
+                $this->assertStringNotContainsString("fatal error:", $output, "Command $type should not have fatal errors");
+            }
+        } finally {
+            // Cleanup
+            if (file_exists($configFile)) {
+                unlink($configFile);
+            }
+        }
+    }
+
+    public function testBinaryEnvironment(): void
+    {
+        // Get environment information
+        $this->assertNotFalse(getenv('PATH'), "PATH environment variable should be set");
+        $this->assertNotFalse(getenv('TEMP'), "TEMP environment variable should be set");
+        $this->assertDirectoryIsWritable(sys_get_temp_dir(), "Temp directory should be writable");
+
+        // Check binary metadata
+        $this->assertGreaterThan(0, filesize($this->binaryPath), "Binary file should not be empty");
+
+        // Verify working directory permissions
+        $cwd = getcwd();
+        $this->assertNotFalse($cwd, "Should be able to get current working directory");
+        $this->assertDirectoryIsWritable($cwd, "Working directory should be writable");
+    }
+
+    public function testBinaryProcessHandling(): void
+    {
+        // Start binary with minimal config
+        $config = [
+            'name' => 'process_test',
+            'virtual_users' => 1,
+            'duration' => '1s',
+            'target' => ['url' => 'http://example.com', 'idle_timeout' => '5s'],
+            'scenarios' => [[
+                'name' => 'test',
+                'steps' => [[
+                    'name' => 'test',
+                    'request' => ['method' => 'GET', 'url' => 'http://example.com']
+                ]]
+            ]]
+        ];
+
+        $configFile = tempnam(sys_get_temp_dir(), 'volt_proc_');
+        $this->assertNotFalse($configFile, "Failed to create temporary config file");
+
+        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
+
+        try {
+            $cmd = escapeshellarg($this->binaryPath) . " -config " . escapeshellarg($configFile);
+            $result = $this->runCommand($cmd);
+
+            $output = implode("\n", $result['output']);
+            $this->assertNotEmpty($output, "Process should produce output");
+            $this->assertNotEquals(-1, $result['code'], "Process should exit normally");
+        } finally {
+            if (file_exists($configFile)) {
+                unlink($configFile);
+            }
+        }
+    }
+}
\ No newline at end of file

From 651d9d0c25aa4076663d05c1148c416658975e2b Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:27:58 +0200
Subject: [PATCH 17/29] WIP

---
 src/Platform.php       |   6 +
 src/ProcessManager.php | 254 ++++++++++++++++++++---------------------
 tests/BinaryTest.php   | 152 ------------------------
 3 files changed, 130 insertions(+), 282 deletions(-)
 delete mode 100644 tests/BinaryTest.php

diff --git a/src/Platform.php b/src/Platform.php
index 9776569..44fa9e2 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -212,6 +212,12 @@ public static function getBinaryPath(): string
             self::installBinary();
         }
 
+        if (PHP_OS_FAMILY === 'Windows' && !is_executable($binaryPath)) {
+            @chmod($binaryPath, 0755);
+        }
+
+        return $binaryPath;
+
         return $binaryPath;
     }
 }
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index fbab8fc..9b4e253 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -1,185 +1,179 @@
 <?php
 
 namespace VoltTest;
+
 use RuntimeException;
 
 class ProcessManager
 {
     private string $binaryPath;
+
     private $currentProcess = null;
-    private bool $debug;
-    private int $timeout = 30;
 
-    public function __construct(string $binaryPath, bool $debug = true)
+    public function __construct(string $binaryPath)
     {
-        $this->binaryPath = str_replace('/', '\\', $binaryPath);
-        $this->debug = $debug;
-
-        if (!file_exists($this->binaryPath)) {
-            throw new RuntimeException("Binary not found at: {$this->binaryPath}");
+        $this->binaryPath = $binaryPath;
+        if (DIRECTORY_SEPARATOR !== '\\' && function_exists('pcntl_async_signals')) {
+            pcntl_async_signals(true);
+            pcntl_signal(SIGINT, [$this, 'handleSignal']);
+            pcntl_signal(SIGTERM, [$this, 'handleSignal']);
         }
-
-        $this->debugLog("ProcessManager initialized with binary: {$this->binaryPath}");
     }
 
-    private function debugLog(string $message): void
+    private function handleSignal(int $signal): void
     {
-        if ($this->debug) {
-            fwrite(STDERR, "[DEBUG] " . date('Y-m-d H:i:s') . " - $message\n");
-            flush();
+        if ($this->currentProcess && is_resource($this->currentProcess)) {
+            proc_terminate($this->currentProcess);
+            proc_close($this->currentProcess);
         }
+        exit(0);
     }
 
     public function execute(array $config, bool $streamOutput): string
     {
-        $this->debugLog("Starting execution");
-
-        // Create temporary directory for test files
-        $tempDir = rtrim(sys_get_temp_dir(), '/\\') . '\\volt_' . uniqid();
-        mkdir($tempDir);
-        $this->debugLog("Created temp directory: $tempDir");
-
-        // Create config file
-        $configFile = $tempDir . '\\config.json';
-        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
-        $this->debugLog("Wrote config to file: $configFile");
-
-        $this->debugLog("config file contain: " . file_get_contents($configFile));
-
-        // Change to temp directory and prepare command
-        $currentDir = getcwd();
-        chdir($tempDir);
-
-        // Prepare command without any flags - the binary should read config.json by default
-        $cmd = sprintf('"%s"', $this->binaryPath);
-        $this->debugLog("Command: $cmd");
-
-        // Start process
-        $descriptorspec = [
-            1 => ['pipe', 'w'],  // stdout
-            2 => ['pipe', 'w']   // stderr
-        ];
-
-        $this->debugLog("Opening process in directory: " . getcwd());
-        $process = proc_open($cmd, $descriptorspec, $pipes, $tempDir, null, [
-            'bypass_shell' => false
-        ]);
+        [$success, $process, $pipes] = $this->openProcess();
+        $this->currentProcess = $process;
 
-        if (!is_resource($process)) {
-            $this->cleanup($tempDir, $currentDir);
-            throw new RuntimeException("Failed to start process");
+        if (! $success || ! is_array($pipes)) {
+            throw new RuntimeException('Failed to start process of volt test');
         }
 
-        $this->currentProcess = $process;
-        $this->debugLog("Process started");
-
         try {
-            // Set streams to non-blocking mode
-            foreach ($pipes as $pipe) {
-                stream_set_blocking($pipe, false);
-            }
+            $this->writeInput($pipes[0], json_encode($config, JSON_PRETTY_PRINT));
+            fclose($pipes[0]);
 
-            $output = '';
-            $startTime = time();
-            $lastDataTime = time();
+            $output = $this->handleProcess($pipes, $streamOutput);
 
-            while (true) {
-                $status = proc_get_status($process);
-                if (!$status['running']) {
-                    $this->debugLog("Process has finished");
-                    break;
-                }
+            // Store stderr content before closing
+            $stderrContent = '';
+            if (isset($pipes[2]) && is_resource($pipes[2])) {
+                rewind($pipes[2]);
+                $stderrContent = stream_get_contents($pipes[2]);
+            }
 
-                // Check timeout
-                if (time() - $startTime > $this->timeout) {
-                    throw new RuntimeException("Process timed out after {$this->timeout} seconds");
+            // Clean up pipes
+            foreach ($pipes as $pipe) {
+                if (is_resource($pipe)) {
+                    fclose($pipe);
                 }
+            }
 
-                $read = $pipes;
-                $write = null;
-                $except = null;
-
-                if (stream_select($read, $write, $except, 0, 200000)) {
-                    foreach ($read as $pipe) {
-                        $data = fread($pipe, 8192);
-                        if ($data === false) {
-                            continue;
-                        }
-                        if ($data !== '') {
-                            $lastDataTime = time();
-                            if ($pipe === $pipes[1]) {
-                                $output .= $data;
-                                if ($streamOutput) {
-                                    fwrite(STDOUT, $data);
-                                    flush();
-                                }
-                            } else {
-                                fwrite(STDERR, $data);
-                                flush();
-                            }
-                        }
-                    }
+            if (is_resource($process)) {
+                $exitCode = $this->closeProcess($process);
+                $this->currentProcess = null;
+                if ($exitCode !== 0) {
+                    echo "\nError: " . trim($stderrContent) . "\n";
+
+                    return '';
                 }
             }
 
-            // Close pipes
+            return $output;
+        } finally {
             foreach ($pipes as $pipe) {
                 if (is_resource($pipe)) {
                     fclose($pipe);
                 }
             }
+            if (is_resource($process)) {
+                $this->closeProcess($process);
+                $this->currentProcess = null;
+            }
+        }
+    }
 
-            $exitCode = proc_close($process);
-            $this->debugLog("Process closed with exit code: $exitCode");
+    protected function openProcess(): array
+    {
+        $pipes = [];
+        $descriptors = [
+            0 => ['pipe', 'r'],
+            1 => ['pipe', 'w'],
+            2 => ['pipe', 'w'],
+        ];
 
-            // Restore original directory and cleanup
-            $this->cleanup($tempDir, $currentDir);
+        // Windows-specific: Remove bypass_shell to allow proper execution
+        $options = DIRECTORY_SEPARATOR === '\\'
+            ? []
+            : ['bypass_shell' => true];
 
-            if ($exitCode !== 0) {
-                throw new RuntimeException("Process failed with exit code $exitCode");
-            }
+        $process = proc_open(
+            escapeshellcmd($this->binaryPath),
+            $descriptors,
+            $pipes,
+            null,
+            null,
+            $options
+        );
 
-            return $output;
+        if (!is_resource($process)) {
+            return [false, null, []];
+        }
 
-        } catch (\Exception $e) {
-            $this->debugLog("Error occurred: " . $e->getMessage());
+        return [true, $process, $pipes];
+    }
 
-            // Clean up
-            foreach ($pipes as $pipe) {
-                if (is_resource($pipe)) {
-                    fclose($pipe);
+    private function handleProcess(array $pipes, bool $streamOutput): string
+    {
+        $output = '';
+
+        while (true) {
+            $read = array_filter($pipes, 'is_resource');
+            if (empty($read)) break;
+
+            $write = $except = null;
+
+            // Windows: Add timeout to prevent infinite blocking
+            $timeout = DIRECTORY_SEPARATOR === '\\' ? 0 : 1;
+            $result = stream_select($read, $write, $except, $timeout);
+
+            if ($result === false) break;
+
+            foreach ($read as $pipe) {
+                $type = array_search($pipe, $pipes, true);
+                $data = fread($pipe, 4096);
+
+                if ($data === false || $data === '') {
+                    if (feof($pipe)) {
+                        fclose($pipe);
+                        unset($pipes[$type]);
+                        continue;
+                    }
                 }
-            }
 
-            if (is_resource($process)) {
-                $status = proc_get_status($process);
-                if ($status['running']) {
-                    exec("taskkill /F /T /PID {$status['pid']} 2>&1", $killOutput, $resultCode);
-                    $this->debugLog("Taskkill result code: $resultCode");
+                if ($type === 1) { // stdout
+                    $output .= $data;
+                    if ($streamOutput) echo $data;
+                } elseif ($type === 2 && $streamOutput) { // stderr
+                    fwrite(STDERR, $data);
                 }
-                proc_close($process);
             }
 
-            // Restore directory and cleanup
-            $this->cleanup($tempDir, $currentDir);
+            // Windows: Add small delay to prevent CPU spike
+            if (DIRECTORY_SEPARATOR === '\\') usleep(100000);
+        }
 
-            throw $e;
+        return $output;
+    }
+
+    protected function writeInput($pipe, string $input): void
+    {
+        if (is_resource($pipe)) {
+            fwrite($pipe, $input);
         }
     }
 
-    private function cleanup(string $tempDir, string $currentDir): void
+    protected function closeProcess($process): int
     {
-        // Restore original directory
-        chdir($currentDir);
-
-        // Clean up temp directory
-        if (file_exists($tempDir)) {
-            $files = glob($tempDir . '/*');
-            foreach ($files as $file) {
-                unlink($file);
-            }
-            rmdir($tempDir);
-            $this->debugLog("Cleaned up temp directory");
+        if (! is_resource($process)) {
+            return -1;
         }
+
+        $status = proc_get_status($process);
+        if ($status['running']) {
+            proc_terminate($process);
+        }
+
+
+        return proc_close($process);
     }
-}
\ No newline at end of file
+}
diff --git a/tests/BinaryTest.php b/tests/BinaryTest.php
deleted file mode 100644
index 7168a76..0000000
--- a/tests/BinaryTest.php
+++ /dev/null
@@ -1,152 +0,0 @@
-<?php
-
-namespace Tests;
-
-use PHPUnit\Framework\TestCase;
-use VoltTest\Platform;
-
-Class BinaryTest extends TestCase
-{
-    private string $binaryPath;
-
-    protected function setUp(): void
-    {
-        $this->binaryPath = Platform::getBinaryPath();
-        $this->assertTrue(file_exists($this->binaryPath), "Binary does not exist at: {$this->binaryPath}");
-        $this->assertTrue(is_executable($this->binaryPath), "Binary is not executable");
-    }
-
-    private function runCommand(string $cmd): array
-    {
-        $output = [];
-        $returnVar = -1;
-        exec($cmd . " 2>&1", $output, $returnVar);
-        return ['output' => $output, 'code' => $returnVar];
-    }
-
-    public function testBinaryBasicExecution(): void
-    {
-        $result = $this->runCommand(escapeshellarg($this->binaryPath));
-        $this->assertNotEmpty($result['output'], "Binary should produce some output");
-    }
-
-    public function testBinaryHelp(): void
-    {
-        $result = $this->runCommand(escapeshellarg($this->binaryPath) . " -h");
-        $this->assertNotEmpty($result['output'], "Help command should produce output");
-        $this->assertStringContainsString("Usage", implode("\n", $result['output']), "Help output should contain usage information");
-    }
-
-    public function testBinaryVersion(): void
-    {
-        $result = $this->runCommand(escapeshellarg($this->binaryPath) . " -v");
-        $this->assertNotEmpty($result['output'], "Version command should produce output");
-    }
-
-    public function testBinaryWithConfig(): void
-    {
-        // Create test configuration
-        $config = [
-            'name' => 'test',
-            'description' => 'test',
-            'virtual_users' => 1,
-            'duration' => '5s',
-            'target' => [
-                'url' => 'http://example.com',
-                'idle_timeout' => '30s'
-            ],
-            'scenarios' => [[
-                'name' => 'test',
-                'steps' => [[
-                    'name' => 'test',
-                    'request' => [
-                        'method' => 'GET',
-                        'url' => 'http://example.com'
-                    ]
-                ]]
-            ]]
-        ];
-
-        // Create temporary config file
-        $configFile = tempnam(sys_get_temp_dir(), 'volt_test_');
-        $this->assertNotFalse($configFile, "Failed to create temporary config file");
-
-        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
-
-        try {
-            // Test different ways of passing config
-            $testCommands = [
-                'standard' => escapeshellarg($this->binaryPath) . " -config " . escapeshellarg($configFile),
-                'short' => escapeshellarg($this->binaryPath) . " -f " . escapeshellarg($configFile),
-                'input' => escapeshellarg($this->binaryPath) . " -input " . escapeshellarg($configFile),
-                'stdin' => "type " . escapeshellarg($configFile) . " | " . escapeshellarg($this->binaryPath)
-            ];
-
-            foreach ($testCommands as $type => $cmd) {
-                $result = $this->runCommand($cmd);
-                $output = implode("\n", $result['output']);
-
-                $this->assertNotEmpty($output, "Command $type should produce output");
-                $this->assertStringNotContainsString("panic:", $output, "Command $type should not panic");
-                $this->assertStringNotContainsString("fatal error:", $output, "Command $type should not have fatal errors");
-            }
-        } finally {
-            // Cleanup
-            if (file_exists($configFile)) {
-                unlink($configFile);
-            }
-        }
-    }
-
-    public function testBinaryEnvironment(): void
-    {
-        // Get environment information
-        $this->assertNotFalse(getenv('PATH'), "PATH environment variable should be set");
-        $this->assertNotFalse(getenv('TEMP'), "TEMP environment variable should be set");
-        $this->assertDirectoryIsWritable(sys_get_temp_dir(), "Temp directory should be writable");
-
-        // Check binary metadata
-        $this->assertGreaterThan(0, filesize($this->binaryPath), "Binary file should not be empty");
-
-        // Verify working directory permissions
-        $cwd = getcwd();
-        $this->assertNotFalse($cwd, "Should be able to get current working directory");
-        $this->assertDirectoryIsWritable($cwd, "Working directory should be writable");
-    }
-
-    public function testBinaryProcessHandling(): void
-    {
-        // Start binary with minimal config
-        $config = [
-            'name' => 'process_test',
-            'virtual_users' => 1,
-            'duration' => '1s',
-            'target' => ['url' => 'http://example.com', 'idle_timeout' => '5s'],
-            'scenarios' => [[
-                'name' => 'test',
-                'steps' => [[
-                    'name' => 'test',
-                    'request' => ['method' => 'GET', 'url' => 'http://example.com']
-                ]]
-            ]]
-        ];
-
-        $configFile = tempnam(sys_get_temp_dir(), 'volt_proc_');
-        $this->assertNotFalse($configFile, "Failed to create temporary config file");
-
-        file_put_contents($configFile, json_encode($config, JSON_PRETTY_PRINT));
-
-        try {
-            $cmd = escapeshellarg($this->binaryPath) . " -config " . escapeshellarg($configFile);
-            $result = $this->runCommand($cmd);
-
-            $output = implode("\n", $result['output']);
-            $this->assertNotEmpty($output, "Process should produce output");
-            $this->assertNotEquals(-1, $result['code'], "Process should exit normally");
-        } finally {
-            if (file_exists($configFile)) {
-                unlink($configFile);
-            }
-        }
-    }
-}
\ No newline at end of file

From 9d0d7e090090422cd7f397f248024e0285641004 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 19:46:44 +0200
Subject: [PATCH 18/29] WIP

---
 src/Platform.php       |  2 ++
 src/ProcessManager.php | 13 ++++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/src/Platform.php b/src/Platform.php
index 44fa9e2..fadbf82 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -77,6 +77,8 @@ private static function detectPlatform($testing = false): string
         }
         $os = strtolower(PHP_OS);
         $arch = php_uname('m');
+        $arch = str_replace(['AMD64', 'AWD64'], 'amd64', $arch);
+        $arch = strtolower($arch);
 
         if (strpos($os, 'win') === 0) {
             $os = 'windows';
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 9b4e253..1389d0e 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -115,10 +115,13 @@ protected function openProcess(): array
     private function handleProcess(array $pipes, bool $streamOutput): string
     {
         $output = '';
+        $timeout = DIRECTORY_SEPARATOR === '\\' ? 0 : 1;
 
         while (true) {
             $read = array_filter($pipes, 'is_resource');
             if (empty($read)) break;
+            stream_set_blocking($pipes[1], false);
+            stream_set_blocking($pipes[2], false);
 
             $write = $except = null;
 
@@ -168,12 +171,16 @@ protected function closeProcess($process): int
             return -1;
         }
 
-        $status = proc_get_status($process);
-        if ($status['running']) {
+        // Windows-specific termination sequence
+        if (DIRECTORY_SEPARATOR === '\\') {
             proc_terminate($process);
+            usleep(100000); // Allow time for termination
+            $status = proc_get_status($process);
+            if ($status['running']) {
+                proc_terminate($process, SIGKILL);
+            }
         }
 
-
         return proc_close($process);
     }
 }

From 2b77f2ba13db0e0cf50a4d019b7a1847ef6c571e Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 20:10:26 +0200
Subject: [PATCH 19/29] WIP

---
 src/ProcessManager.php | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 1389d0e..72e2d85 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -7,7 +7,6 @@
 class ProcessManager
 {
     private string $binaryPath;
-
     private $currentProcess = null;
 
     public function __construct(string $binaryPath)
@@ -63,7 +62,6 @@ public function execute(array $config, bool $streamOutput): string
                 $this->currentProcess = null;
                 if ($exitCode !== 0) {
                     echo "\nError: " . trim($stderrContent) . "\n";
-
                     return '';
                 }
             }
@@ -174,7 +172,7 @@ protected function closeProcess($process): int
         // Windows-specific termination sequence
         if (DIRECTORY_SEPARATOR === '\\') {
             proc_terminate($process);
-            usleep(100000); // Allow time for termination
+            usleep(100000);
             $status = proc_get_status($process);
             if ($status['running']) {
                 proc_terminate($process, SIGKILL);

From 775a75b1e6e713ee841639ad94beda26ed3f4810 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 20:16:32 +0200
Subject: [PATCH 20/29] WIP

---
 src/Platform.php       | 10 +------
 src/ProcessManager.php | 65 ++++++++++++++++++------------------------
 2 files changed, 28 insertions(+), 47 deletions(-)

diff --git a/src/Platform.php b/src/Platform.php
index fadbf82..20b2ff8 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -77,8 +77,6 @@ private static function detectPlatform($testing = false): string
         }
         $os = strtolower(PHP_OS);
         $arch = php_uname('m');
-        $arch = str_replace(['AMD64', 'AWD64'], 'amd64', $arch);
-        $arch = strtolower($arch);
 
         if (strpos($os, 'win') === 0) {
             $os = 'windows';
@@ -214,12 +212,6 @@ public static function getBinaryPath(): string
             self::installBinary();
         }
 
-        if (PHP_OS_FAMILY === 'Windows' && !is_executable($binaryPath)) {
-            @chmod($binaryPath, 0755);
-        }
-
-        return $binaryPath;
-
         return $binaryPath;
     }
-}
+}
\ No newline at end of file
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index 72e2d85..dd009d7 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -7,12 +7,13 @@
 class ProcessManager
 {
     private string $binaryPath;
+
     private $currentProcess = null;
 
     public function __construct(string $binaryPath)
     {
         $this->binaryPath = $binaryPath;
-        if (DIRECTORY_SEPARATOR !== '\\' && function_exists('pcntl_async_signals')) {
+        if (function_exists('pcntl_async_signals')) {
             pcntl_async_signals(true);
             pcntl_signal(SIGINT, [$this, 'handleSignal']);
             pcntl_signal(SIGTERM, [$this, 'handleSignal']);
@@ -62,6 +63,7 @@ public function execute(array $config, bool $streamOutput): string
                 $this->currentProcess = null;
                 if ($exitCode !== 0) {
                     echo "\nError: " . trim($stderrContent) . "\n";
+
                     return '';
                 }
             }
@@ -83,27 +85,20 @@ public function execute(array $config, bool $streamOutput): string
     protected function openProcess(): array
     {
         $pipes = [];
-        $descriptors = [
-            0 => ['pipe', 'r'],
-            1 => ['pipe', 'w'],
-            2 => ['pipe', 'w'],
-        ];
-
-        // Windows-specific: Remove bypass_shell to allow proper execution
-        $options = DIRECTORY_SEPARATOR === '\\'
-            ? []
-            : ['bypass_shell' => true];
-
         $process = proc_open(
-            escapeshellcmd($this->binaryPath),
-            $descriptors,
+            $this->binaryPath,
+            [
+                0 => ['pipe', 'r'],
+                1 => ['pipe', 'w'],
+                2 => ['pipe', 'w'],
+            ],
             $pipes,
             null,
             null,
-            $options
+            ['bypass_shell' => true]
         );
 
-        if (!is_resource($process)) {
+        if (! is_resource($process)) {
             return [false, null, []];
         }
 
@@ -113,21 +108,19 @@ protected function openProcess(): array
     private function handleProcess(array $pipes, bool $streamOutput): string
     {
         $output = '';
-        $timeout = DIRECTORY_SEPARATOR === '\\' ? 0 : 1;
 
         while (true) {
             $read = array_filter($pipes, 'is_resource');
-            if (empty($read)) break;
-            stream_set_blocking($pipes[1], false);
-            stream_set_blocking($pipes[2], false);
-
-            $write = $except = null;
+            if (empty($read)) {
+                break;
+            }
 
-            // Windows: Add timeout to prevent infinite blocking
-            $timeout = DIRECTORY_SEPARATOR === '\\' ? 0 : 1;
-            $result = stream_select($read, $write, $except, $timeout);
+            $write = null;
+            $except = null;
 
-            if ($result === false) break;
+            if (stream_select($read, $write, $except, 1) === false) {
+                break;
+            }
 
             foreach ($read as $pipe) {
                 $type = array_search($pipe, $pipes, true);
@@ -137,20 +130,20 @@ private function handleProcess(array $pipes, bool $streamOutput): string
                     if (feof($pipe)) {
                         fclose($pipe);
                         unset($pipes[$type]);
+
                         continue;
                     }
                 }
 
                 if ($type === 1) { // stdout
                     $output .= $data;
-                    if ($streamOutput) echo $data;
+                    if ($streamOutput) {
+                        echo $data;
+                    }
                 } elseif ($type === 2 && $streamOutput) { // stderr
                     fwrite(STDERR, $data);
                 }
             }
-
-            // Windows: Add small delay to prevent CPU spike
-            if (DIRECTORY_SEPARATOR === '\\') usleep(100000);
         }
 
         return $output;
@@ -169,16 +162,12 @@ protected function closeProcess($process): int
             return -1;
         }
 
-        // Windows-specific termination sequence
-        if (DIRECTORY_SEPARATOR === '\\') {
+        $status = proc_get_status($process);
+        if ($status['running']) {
             proc_terminate($process);
-            usleep(100000);
-            $status = proc_get_status($process);
-            if ($status['running']) {
-                proc_terminate($process, SIGKILL);
-            }
         }
 
+
         return proc_close($process);
     }
-}
+}
\ No newline at end of file

From f459500ca0bb508bf0dca71aeec14ade1c25f34d Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 22:46:54 +0200
Subject: [PATCH 21/29] Refactor CI to run Windows tests inside WSL

---
 .github/workflows/ci.yml | 123 +++++++++++++--------------------------
 1 file changed, 39 insertions(+), 84 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e2366ed..25934e1 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -18,67 +18,54 @@ jobs:
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
         php: [8.0 ,8.1 ,8.2, 8.3, 8.4]
+
     steps:
       - uses: actions/checkout@v4
 
-      # PHP installation and setup using built-in tools
+      # Setup PHP for Linux
       - name: Setup PHP (Ubuntu)
         if: matrix.os == 'ubuntu-latest'
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-curl php8.2-mbstring
+          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-curl php${{ matrix.php }}-mbstring
           php -v
         shell: bash
 
+      # Setup PHP for macOS
       - name: Setup PHP (macOS)
         if: matrix.os == 'macos-latest'
         run: |
-          brew install php@8.2
-          brew link php@8.2 --force
+          brew install php@${{ matrix.php }}
+          brew link php@${{ matrix.php }} --force
           php -v
         shell: bash
 
-      - name: Setup PHP (Windows)
+      # Setup PHP for Windows using WSL
+      - name: Enable WSL and Install PHP
         if: matrix.os == 'windows-latest'
         run: |
-          choco install php --version=8.2 --params '"/ExtensionList:mbstring,curl,openssl,xml"'
-          refreshenv
-          # Download CA bundle
-          Invoke-WebRequest -Uri https://curl.se/ca/cacert.pem -OutFile C:\tools\cacert.pem
-          # Configure PHP to use the CA bundle
-          $phpIni = php --ini | Select-String "Loaded Configuration File" | ForEach-Object { $_.Line.Split()[-1] }
-          Add-Content $phpIni "`nopenssl.cafile = C:\tools\cacert.pem"
-          php -v
+          wsl --install -d Ubuntu
+          wsl sudo apt update
+          wsl sudo apt install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-curl php${{ matrix.php }}-mbstring
+          wsl php -v
         shell: pwsh
 
-      - name: Install Composer (Windows)
+      # Install Composer inside WSL
+      - name: Install Composer (Windows via WSL)
         if: matrix.os == 'windows-latest'
         run: |
-          php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
-          php composer-setup.php
-          php -r "unlink('composer-setup.php');"
-          mkdir -p C:\tools\composer
-          move composer.phar C:\tools\composer\composer
-          echo "C:\tools\composer" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+          wsl php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
+          wsl php composer-setup.php
+          wsl php -r "unlink('composer-setup.php');"
+          wsl sudo mv composer.phar /usr/local/bin/composer
+          wsl sudo chmod +x /usr/local/bin/composer
+          wsl composer -V
         shell: pwsh
 
-      - name: Install Composer (Unix)
-        if: matrix.os != 'windows-latest'
-        run: |
-          php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
-          sudo php composer-setup.php --install-dir=/usr/local/bin --filename=composer
-          php -r "unlink('composer-setup.php');"
-          sudo chmod +x /usr/local/bin/composer
-          mkdir -p ~/.composer
-          if [ "$RUNNER_OS" == "Linux" ]; then
-            sudo chown -R $USER:$USER ~/.composer
-          fi
-        shell: bash
-
       - name: Get Composer Cache Directory
         id: composer-cache
-        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+        run: echo "dir=$(wsl composer config cache-files-dir)" >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Cache Composer packages
@@ -89,17 +76,25 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-composer-
 
-      - name: Install dependencies (Windows)
+      # Install dependencies
+      - name: Install dependencies (Windows via WSL)
         if: matrix.os == 'windows-latest'
-        run: composer install --prefer-dist --no-progress --ignore-platform-req=ext-pcntl
-        shell: bash
+        run: wsl composer install --prefer-dist --no-progress
+        shell: pwsh
 
       - name: Install dependencies (Unix)
         if: matrix.os != 'windows-latest'
         run: composer install --prefer-dist --no-progress
         shell: bash
 
-      - name: Run test suite
+      # Run tests
+      - name: Run test suite (Windows via WSL)
+        if: matrix.os == 'windows-latest'
+        run: wsl vendor/bin/phpunit
+        shell: pwsh
+
+      - name: Run test suite (Unix)
+        if: matrix.os != 'windows-latest'
         run: vendor/bin/phpunit
         shell: bash
 
@@ -126,7 +121,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
+          sudo apt install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
         shell: bash
 
       - name: Install Composer
@@ -137,44 +132,14 @@ jobs:
           sudo chown -R $USER:$USER ~/.composer
         shell: bash
 
-      - name: Get Composer Cache Directory
-        id: composer-cache
-        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
-
-      - name: Cache Composer packages
-        uses: actions/cache@v3
-        with:
-          path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-composer-
-
       - name: Install Dependencies
         run: |
           composer install --prefer-dist --no-progress
           composer require --dev phpstan/phpstan --with-all-dependencies
         shell: bash
 
-      - name: Create PHPStan config
-        run: |
-          echo '
-          parameters:
-              level: 5
-              paths:
-                  - src
-                  - tests
-              excludePaths:
-                  - vendor/*
-          ' > phpstan.neon
-
       - name: Run PHPStan
-        run: |
-          if [ -f "vendor/bin/phpstan" ]; then
-            vendor/bin/phpstan analyse -c phpstan.neon
-          else
-            echo "PHPStan not found in vendor/bin"
-            exit 1
-          fi
+        run: vendor/bin/phpstan analyse --level=5 src tests
         shell: bash
 
   code-style:
@@ -190,7 +155,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
+          sudo apt install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
         shell: bash
 
       - name: Install Composer
@@ -201,18 +166,6 @@ jobs:
           sudo chown -R $USER:$USER ~/.composer
         shell: bash
 
-      - name: Get Composer Cache Directory
-        id: composer-cache
-        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
-
-      - name: Cache Composer packages
-        uses: actions/cache@v3
-        with:
-          path: ${{ steps.composer-cache.outputs.dir }}
-          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
-          restore-keys: |
-            ${{ runner.os }}-composer-
-
       - name: Install Dependencies
         run: |
           composer install --prefer-dist --no-progress
@@ -235,6 +188,8 @@ jobs:
                       ->in(__DIR__)
               );
           " > .php-cs-fixer.php
+        shell: bash
 
       - name: Check coding standards
-        run: vendor/bin/php-cs-fixer fix --dry-run --diff
\ No newline at end of file
+        run: vendor/bin/php-cs-fixer fix --dry-run --diff
+        shell: bash

From c2af84be91c69a1a07834020882a5a79de88eda6 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 22:50:55 +0200
Subject: [PATCH 22/29] wsl not working in ci

---
 .github/workflows/ci.yml | 23 +----------------------
 1 file changed, 1 insertion(+), 22 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 25934e1..3104353 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-latest, windows-latest, macos-latest]
+        os: [ubuntu-latest, macos-latest]
         php: [8.0 ,8.1 ,8.2, 8.3, 8.4]
 
     steps:
@@ -41,27 +41,6 @@ jobs:
           php -v
         shell: bash
 
-      # Setup PHP for Windows using WSL
-      - name: Enable WSL and Install PHP
-        if: matrix.os == 'windows-latest'
-        run: |
-          wsl --install -d Ubuntu
-          wsl sudo apt update
-          wsl sudo apt install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-curl php${{ matrix.php }}-mbstring
-          wsl php -v
-        shell: pwsh
-
-      # Install Composer inside WSL
-      - name: Install Composer (Windows via WSL)
-        if: matrix.os == 'windows-latest'
-        run: |
-          wsl php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
-          wsl php composer-setup.php
-          wsl php -r "unlink('composer-setup.php');"
-          wsl sudo mv composer.phar /usr/local/bin/composer
-          wsl sudo chmod +x /usr/local/bin/composer
-          wsl composer -V
-        shell: pwsh
 
       - name: Get Composer Cache Directory
         id: composer-cache

From 06ee5e18e653e680a300292cfc869e8f90b91e14 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 22:55:55 +0200
Subject: [PATCH 23/29] ci

---
 .github/workflows/ci.yml | 79 +++++++++++++++++++++++++---------------
 1 file changed, 50 insertions(+), 29 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3104353..df6d6ee 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,12 +17,11 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest]
-        php: [8.0 ,8.1 ,8.2, 8.3, 8.4]
-
+        php: [8.0 ,8.1 ,8.2, 8.3]
     steps:
       - uses: actions/checkout@v4
 
-      # Setup PHP for Linux
+      # PHP installation and setup using built-in tools
       - name: Setup PHP (Ubuntu)
         if: matrix.os == 'ubuntu-latest'
         run: |
@@ -32,7 +31,6 @@ jobs:
           php -v
         shell: bash
 
-      # Setup PHP for macOS
       - name: Setup PHP (macOS)
         if: matrix.os == 'macos-latest'
         run: |
@@ -41,10 +39,9 @@ jobs:
           php -v
         shell: bash
 
-
       - name: Get Composer Cache Directory
         id: composer-cache
-        run: echo "dir=$(wsl composer config cache-files-dir)" >> $GITHUB_OUTPUT
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
         shell: bash
 
       - name: Cache Composer packages
@@ -55,25 +52,9 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-composer-
 
-      # Install dependencies
-      - name: Install dependencies (Windows via WSL)
-        if: matrix.os == 'windows-latest'
-        run: wsl composer install --prefer-dist --no-progress
-        shell: pwsh
-
-      - name: Install dependencies (Unix)
-        if: matrix.os != 'windows-latest'
-        run: composer install --prefer-dist --no-progress
-        shell: bash
 
-      # Run tests
-      - name: Run test suite (Windows via WSL)
-        if: matrix.os == 'windows-latest'
-        run: wsl vendor/bin/phpunit
-        shell: pwsh
 
-      - name: Run test suite (Unix)
-        if: matrix.os != 'windows-latest'
+      - name: Run test suite
         run: vendor/bin/phpunit
         shell: bash
 
@@ -100,7 +81,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
+          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-mbstring
         shell: bash
 
       - name: Install Composer
@@ -111,14 +92,44 @@ jobs:
           sudo chown -R $USER:$USER ~/.composer
         shell: bash
 
+      - name: Get Composer Cache Directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache Composer packages
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
       - name: Install Dependencies
         run: |
           composer install --prefer-dist --no-progress
           composer require --dev phpstan/phpstan --with-all-dependencies
         shell: bash
 
+      - name: Create PHPStan config
+        run: |
+          echo '
+          parameters:
+              level: 5
+              paths:
+                  - src
+                  - tests
+              excludePaths:
+                  - vendor/*
+          ' > phpstan.neon
+
       - name: Run PHPStan
-        run: vendor/bin/phpstan analyse --level=5 src tests
+        run: |
+          if [ -f "vendor/bin/phpstan" ]; then
+            vendor/bin/phpstan analyse -c phpstan.neon
+          else
+            echo "PHPStan not found in vendor/bin"
+            exit 1
+          fi
         shell: bash
 
   code-style:
@@ -134,7 +145,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
+          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-mbstring
         shell: bash
 
       - name: Install Composer
@@ -145,6 +156,18 @@ jobs:
           sudo chown -R $USER:$USER ~/.composer
         shell: bash
 
+      - name: Get Composer Cache Directory
+        id: composer-cache
+        run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
+
+      - name: Cache Composer packages
+        uses: actions/cache@v3
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-composer-
+
       - name: Install Dependencies
         run: |
           composer install --prefer-dist --no-progress
@@ -167,8 +190,6 @@ jobs:
                       ->in(__DIR__)
               );
           " > .php-cs-fixer.php
-        shell: bash
 
       - name: Check coding standards
-        run: vendor/bin/php-cs-fixer fix --dry-run --diff
-        shell: bash
+        run: vendor/bin/php-cs-fixer fix --dry-run --diff
\ No newline at end of file

From 115d40b4d56693a80370583bbce8cc71a1861ca1 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 22:58:51 +0200
Subject: [PATCH 24/29] remove version of matrix from php

---
 .github/workflows/ci.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index df6d6ee..8ad5d7d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -27,7 +27,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-curl php${{ matrix.php }}-mbstring
+          sudo apt-get install -y php php-cli php-xml php-curl php-mbstring
           php -v
         shell: bash
 
@@ -81,7 +81,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-mbstring
+          sudo apt-get install -y php php-cli php-xml php-mbstring
         shell: bash
 
       - name: Install Composer
@@ -145,7 +145,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php${{ matrix.php }} php${{ matrix.php }}-cli php${{ matrix.php }}-xml php${{ matrix.php }}-mbstring
+          sudo apt-get install -y php php-cli php-xml php-mbstring
         shell: bash
 
       - name: Install Composer

From 487e804a4a5f62268717e34b430230b7f94edb3f Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 23:00:13 +0200
Subject: [PATCH 25/29] mac php

---
 .github/workflows/ci.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8ad5d7d..88b1cae 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -34,8 +34,8 @@ jobs:
       - name: Setup PHP (macOS)
         if: matrix.os == 'macos-latest'
         run: |
-          brew install php@${{ matrix.php }}
-          brew link php@${{ matrix.php }} --force
+          brew install php
+          brew link php --force
           php -v
         shell: bash
 

From 7689436fc97c4c0ca81ebef97bec2c2eba2c413b Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 23:01:09 +0200
Subject: [PATCH 26/29] php version

---
 .github/workflows/ci.yml | 57 +++++++++++++++++++++++++++++++++++-----
 1 file changed, 51 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 88b1cae..36d8b21 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest]
-        php: [8.0 ,8.1 ,8.2, 8.3]
+        php: [8.0 ,8.1 ,8.2, 8.3, 8.4]
     steps:
       - uses: actions/checkout@v4
 
@@ -27,18 +27,55 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php php-cli php-xml php-curl php-mbstring
+          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-curl php8.2-mbstring
           php -v
         shell: bash
 
       - name: Setup PHP (macOS)
         if: matrix.os == 'macos-latest'
         run: |
-          brew install php
-          brew link php --force
+          brew install php@8.2
+          brew link php@8.2 --force
           php -v
         shell: bash
 
+      - name: Setup PHP (Windows)
+        if: matrix.os == 'windows-latest'
+        run: |
+          choco install php --version=8.2 --params '"/ExtensionList:mbstring,curl,openssl,xml"'
+          refreshenv
+          # Download CA bundle
+          Invoke-WebRequest -Uri https://curl.se/ca/cacert.pem -OutFile C:\tools\cacert.pem
+          # Configure PHP to use the CA bundle
+          $phpIni = php --ini | Select-String "Loaded Configuration File" | ForEach-Object { $_.Line.Split()[-1] }
+          Add-Content $phpIni "`nopenssl.cafile = C:\tools\cacert.pem"
+          php -v
+        shell: pwsh
+
+      - name: Install Composer (Windows)
+        if: matrix.os == 'windows-latest'
+        run: |
+          php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
+          php composer-setup.php
+          php -r "unlink('composer-setup.php');"
+          mkdir -p C:\tools\composer
+          move composer.phar C:\tools\composer\composer
+          echo "C:\tools\composer" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
+        shell: pwsh
+
+      - name: Install Composer (Unix)
+        if: matrix.os != 'windows-latest'
+        run: |
+          php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
+          sudo php composer-setup.php --install-dir=/usr/local/bin --filename=composer
+          php -r "unlink('composer-setup.php');"
+          sudo chmod +x /usr/local/bin/composer
+          mkdir -p ~/.composer
+          if [ "$RUNNER_OS" == "Linux" ]; then
+            sudo chown -R $USER:$USER ~/.composer
+          fi
+        shell: bash
+
       - name: Get Composer Cache Directory
         id: composer-cache
         run: echo "dir=$(composer config cache-files-dir)" >> $GITHUB_OUTPUT
@@ -52,7 +89,15 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-composer-
 
+      - name: Install dependencies (Windows)
+        if: matrix.os == 'windows-latest'
+        run: composer install --prefer-dist --no-progress --ignore-platform-req=ext-pcntl
+        shell: bash
 
+      - name: Install dependencies (Unix)
+        if: matrix.os != 'windows-latest'
+        run: composer install --prefer-dist --no-progress
+        shell: bash
 
       - name: Run test suite
         run: vendor/bin/phpunit
@@ -81,7 +126,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php php-cli php-xml php-mbstring
+          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
         shell: bash
 
       - name: Install Composer
@@ -145,7 +190,7 @@ jobs:
         run: |
           sudo add-apt-repository ppa:ondrej/php
           sudo apt-get update
-          sudo apt-get install -y php php-cli php-xml php-mbstring
+          sudo apt-get install -y php8.2 php8.2-cli php8.2-xml php8.2-mbstring
         shell: bash
 
       - name: Install Composer

From 4faa736d0bf4b69d183a4c4cd3eda9968efd4ba4 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 23:03:27 +0200
Subject: [PATCH 27/29] ci

---
 src/Platform.php       |  2 +-
 src/ProcessManager.php |  2 +-
 tests/VoltTestTest.php | 53 ++++++++++++++++++++++++++++++++++--------
 3 files changed, 45 insertions(+), 12 deletions(-)

diff --git a/src/Platform.php b/src/Platform.php
index 20b2ff8..9776569 100644
--- a/src/Platform.php
+++ b/src/Platform.php
@@ -214,4 +214,4 @@ public static function getBinaryPath(): string
 
         return $binaryPath;
     }
-}
\ No newline at end of file
+}
diff --git a/src/ProcessManager.php b/src/ProcessManager.php
index dd009d7..9877eaa 100644
--- a/src/ProcessManager.php
+++ b/src/ProcessManager.php
@@ -170,4 +170,4 @@ protected function closeProcess($process): int
 
         return proc_close($process);
     }
-}
\ No newline at end of file
+}
diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index 2fa59ab..037f19f 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -21,22 +21,55 @@ protected function tearDown(): void
         ErrorHandler::unregister();
         parent::tearDown();
     }
+
     public function testVoltTest()
     {
         $voltTest = new VoltTest("test");
         $voltTest->setVirtualUsers(10);
+
+        // Create first scenario
         $scenario1 = $voltTest->scenario("Test Scenario")->setWeight(10);
-        $scenario1->step("Step 1")->get('https://www.google.com');
+        $scenario1->step("Step 1")
+            ->get('https://www.google.com')
+            ->validateStatus('success', 200);
+
+        // Create second scenario
         $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
-        $scenario2->step("Step 1")->get('https://www.google.com');
+        $scenario2->step("Step 1")
+            ->get('https://www.google.com')
+            ->validateStatus('success', 200);
+
+        // Run test and get results
         $result = $voltTest->run(true);
-        var_dump($result->getDuration());
-        $this->assertNotEquals('0', $result->getDuration(), "Duration should not be 0");
-        $this->assertNotNull($result->getAvgResponseTime(), "Average response time should not be null");
-
-        $this->assertIsFloat($result->getSuccessRate(), "Success rate should be a float");
-        $this->assertIsInt($result->getTotalRequests(), "Total requests should be an integer");
-        $this->assertIsInt($result->getSuccessRequests(), "Success requests should be an integer");
-        $this->assertIsInt($result->getFailedRequests(), "Failed requests should be an integer");
+
+        // Basic assertions about test execution
+        $this->assertNotEmpty($result->getRawOutput(), "Raw output should not be empty");
+
+        // Get duration and remove any 's' suffix if present
+        $duration = str_replace('s', '', $result->getDuration());
+        $this->assertNotEquals(0, (float)$duration, "Duration should not be 0");
+
+        // Verify response time metrics
+        $avgResponseTime = $result->getAvgResponseTime();
+        if ($avgResponseTime !== null) {
+            $this->assertStringContainsString('ms', $avgResponseTime, "Average response time should contain 'ms'");
+        }
+
+        // Test rate metrics
+        $this->assertGreaterThan(0, $result->getSuccessRate(), "Success rate should be greater than 0");
+        $this->assertGreaterThanOrEqual(0, $result->getRequestsPerSecond(), "Requests per second should be non-negative");
+
+        // Request counts
+        $this->assertGreaterThan(0, $result->getTotalRequests(), "Total requests should be greater than 0");
+        $this->assertGreaterThanOrEqual(0, $result->getSuccessRequests(), "Success requests should be non-negative");
+        $this->assertGreaterThanOrEqual(0, $result->getFailedRequests(), "Failed requests should be non-negative");
+
+        // Total requests should equal success + failed requests
+        $this->assertEquals(
+            $result->getTotalRequests(),
+            $result->getSuccessRequests() + $result->getFailedRequests(),
+            "Total requests should equal sum of success and failed requests"
+        );
+
     }
 }

From bfc5782dd04f23c1bb89f273110804fdd04d292a Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 23:15:51 +0200
Subject: [PATCH 28/29] confirm that the volt test engine working

---
 tests/VoltTestTest.php | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index 037f19f..5482e58 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -28,27 +28,19 @@ public function testVoltTest()
         $voltTest->setVirtualUsers(10);
 
         // Create first scenario
-        $scenario1 = $voltTest->scenario("Test Scenario")->setWeight(10);
+        $scenario1 = $voltTest->scenario("Test Scenario")->setWeight(100);
         $scenario1->step("Step 1")
             ->get('https://www.google.com')
+            ->setThinkTime('1s')
             ->validateStatus('success', 200);
 
-        // Create second scenario
-        $scenario2 = $voltTest->scenario("Test Scenario 2")->setWeight(90);
-        $scenario2->step("Step 1")
+        $scenario1->step("Step 2")
             ->get('https://www.google.com')
+            ->setThinkTime('1s')
             ->validateStatus('success', 200);
 
-        // Run test and get results
         $result = $voltTest->run(true);
 
-        // Basic assertions about test execution
-        $this->assertNotEmpty($result->getRawOutput(), "Raw output should not be empty");
-
-        // Get duration and remove any 's' suffix if present
-        $duration = str_replace('s', '', $result->getDuration());
-        $this->assertNotEquals(0, (float)$duration, "Duration should not be 0");
-
         // Verify response time metrics
         $avgResponseTime = $result->getAvgResponseTime();
         if ($avgResponseTime !== null) {

From c5d1278832e92fdffd10cf53bc85cba468b09622 Mon Sep 17 00:00:00 2001
From: elwafa <eslamaboelwafa@gmail.com>
Date: Wed, 29 Jan 2025 23:16:26 +0200
Subject: [PATCH 29/29] dump avgResponse time

---
 tests/VoltTestTest.php | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/tests/VoltTestTest.php b/tests/VoltTestTest.php
index 5482e58..c660b84 100644
--- a/tests/VoltTestTest.php
+++ b/tests/VoltTestTest.php
@@ -25,7 +25,7 @@ protected function tearDown(): void
     public function testVoltTest()
     {
         $voltTest = new VoltTest("test");
-        $voltTest->setVirtualUsers(10);
+        $voltTest->setVirtualUsers(1);
 
         // Create first scenario
         $scenario1 = $voltTest->scenario("Test Scenario")->setWeight(100);
@@ -43,25 +43,10 @@ public function testVoltTest()
 
         // Verify response time metrics
         $avgResponseTime = $result->getAvgResponseTime();
+        var_dump($avgResponseTime);
         if ($avgResponseTime !== null) {
             $this->assertStringContainsString('ms', $avgResponseTime, "Average response time should contain 'ms'");
         }
 
-        // Test rate metrics
-        $this->assertGreaterThan(0, $result->getSuccessRate(), "Success rate should be greater than 0");
-        $this->assertGreaterThanOrEqual(0, $result->getRequestsPerSecond(), "Requests per second should be non-negative");
-
-        // Request counts
-        $this->assertGreaterThan(0, $result->getTotalRequests(), "Total requests should be greater than 0");
-        $this->assertGreaterThanOrEqual(0, $result->getSuccessRequests(), "Success requests should be non-negative");
-        $this->assertGreaterThanOrEqual(0, $result->getFailedRequests(), "Failed requests should be non-negative");
-
-        // Total requests should equal success + failed requests
-        $this->assertEquals(
-            $result->getTotalRequests(),
-            $result->getSuccessRequests() + $result->getFailedRequests(),
-            "Total requests should equal sum of success and failed requests"
-        );
-
     }
 }