-
Notifications
You must be signed in to change notification settings - Fork 295
Rename 'Plugin' & 'Config' to 'Hook' and 'HookConfig' #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dherman
merged 15 commits into
volta-cli:master
from
charlespierce:rename_config_to_hooks
Feb 7, 2019
Merged
Rename 'Plugin' & 'Config' to 'Hook' and 'HookConfig' #241
dherman
merged 15 commits into
volta-cli:master
from
charlespierce:rename_config_to_hooks
Feb 7, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved Merge Conflicts |
dherman
requested changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Just a few small suggestions.
dherman
approved these changes
Feb 7, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exciting work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the changes discussed in volta-cli/rfcs#25
Changes
config
andplugin
modules into a single modules namedhook
.Inventory::fetch
andDistro
construction to reference the hooks and use them to resolve the URLs necessary for locating the latest version, index and specific distro download.Prefix
andTemplate
).Notes
node
hooks forlatest
andindex
are currently treated the same way, they download the index, which is then searched to find the appropriate version. This will probably need to be documented, or if Node has an URL we can hit in the same way as the Yarnlatest-version
endpoint to determine the latest version, we can migrate to that.