get_user_command skips a user every time a command is found

[Voltara]

/* find and return a user command */
for (i = 0; i < max_users; i++) {
    ip = all_users[NextCmdGiver++];
    NextCmdGiver %= max_users;

    /* ... */

    /* if there's a command in the buffer, pull it out! */
    if (ip->iflags & CMD_IN_BUF) {
        NextCmdGiver++;
        NextCmdGiver %= max_users;
        user_command = first_cmd_in_buf(ip);
        break;
    }

It is not necessary to increment NextCmdGiver a second time; this allows one user to starve another of command processing time.

[thefallentree]

good find!