Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to use this library with React 17.x.x #9

Closed
k-paxian opened this issue Jul 21, 2021 · 1 comment
Closed

Not able to use this library with React 17.x.x #9

k-paxian opened this issue Jul 21, 2021 · 1 comment
Assignees

Comments

@k-paxian
Copy link
Collaborator

k-paxian commented Jul 21, 2021

based on this tread: https://vonage.slack.com/archives/C013F0YKH99/p1620125470174000

import './App.css';
import React from 'react';
import VwcButton from '@vonage/vivid-react/VwcButton';
function App() {
  return <VwcButton />
}
export default App;

image

@k-paxian k-paxian self-assigned this Jul 21, 2021
k-paxian added a commit that referenced this issue Jul 21, 2021
* refine package dependencies
* move React to peerDependencies section to enable different react versions
@k-paxian
Copy link
Collaborator Author

k-paxian commented Jul 21, 2021

Apparently, the issue were to have a React as a direct dependency instead of peerDependency

So the statement above: "3. You might have more than one copy of React in the same App" appears to be true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant