Skip to content

Commit

Permalink
Fixing false positive spec
Browse files Browse the repository at this point in the history
  • Loading branch information
voodoorai2000 committed Jun 25, 2014
1 parent 62c454f commit 9d17ebf
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions spec/factories/circle.rb
@@ -1,8 +1,9 @@
FactoryGirl.define do
factory :circle do
name Faker::Company.name
kind %w(group page user).sample

name Faker::Company.name
kind %w(group page user).sample
constituted_at Date.today

trait :recent do
revised false
end
Expand Down
6 changes: 3 additions & 3 deletions spec/models/circle_spec.rb
Expand Up @@ -3,10 +3,10 @@
describe Circle do
context 'listings' do
it 'ordered by constituted_at' do
first_circle = create(:circle)
create_list(:circle, 5)
first_circle = create(:circle, constituted_at: Date.today)
second_circle = create(:circle, constituted_at: 1.day.ago)

expect(Circle.all.first).to eq(first_circle)
expect(Circle.first).to eq(first_circle)
end

it 'by recent (or not revised)' do
Expand Down

5 comments on commit 9d17ebf

@rgo
Copy link
Collaborator

@rgo rgo commented on 9d17ebf Jun 26, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! I forgot to move commit into a new branch and do a pull request

@voodoorai2000
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's cool ;) but yes it be nice to work mainly with branches and pull requests.
I like the Github Flow http://scottchacon.com/2011/08/31/github-flow.html

What you think?

@rgo
Copy link
Collaborator

@rgo rgo commented on 9d17ebf Jun 26, 2014 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davilious
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@voodoorai2000
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Please sign in to comment.