Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tokio 0.2 and hyper 0.13 support #45

vorner opened this issue Nov 8, 2019 · 0 comments


Copy link

@vorner vorner commented Nov 8, 2019

Both tokio and hyper are going to release new line of stable versions soon and it would be great to support them. I assume there'll need to be some changes done in spirit-tokio and spirit-hyper to support these, not just bumping the version of dependency. But I also assume most of the things will be similar (renamed, moved somewhere else, ...).

It is probably a too big endeavour to change everything in one go, so I'd suggest to disable spirit-hyper completely at first, comment out few modules of spirit-tokio, change the dependency and see what breaks and start fixing it. And them re-add the modules one at a time, make compile and then add more. I'll be happy to review and help during the process, by smaller chunks.

There are alpha versions released, so the porting can be started against them and hopefully later on just point to the stable version once it gets released.

I'll offer to help out whoever takes this one onto themselves by means of reviews, answering questions, or lightweight mentoring (within limited time).

If you want to work on this, please write a comment to claim it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.