Skip to content

fix issue with FileSystem path handling#8248

Open
robert3005 wants to merge 4 commits into
developfrom
rk/verify-exact-path
Open

fix issue with FileSystem path handling#8248
robert3005 wants to merge 4 commits into
developfrom
rk/verify-exact-path

Conversation

@robert3005

@robert3005 robert3005 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

fix #6599

this is a revival of #7516 that needed some extra love

In this pr we make sure to handle all the edge cases of paths that work differently locally vs over http. This is in addition to #7516 which fixed glob handling of non existent files

a10y and others added 2 commits June 4, 2026 13:41
Signed-off-by: Andrew Duffy <andrew@a10y.dev>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 requested a review from a10y June 4, 2026 13:39
@robert3005 robert3005 added the changelog/fix A bug fix label Jun 4, 2026
Signed-off-by: Robert Kruszewski <github@robertk.io>
@joseph-isaacs

Copy link
Copy Markdown
Contributor

should be also handle esc and % codes

Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005

Copy link
Copy Markdown
Contributor Author

I have made the coverage more expansive. It boils down to using Path::parse instead of Path::from

@codspeed-hq

codspeed-hq Bot commented Jun 4, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 23.16%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

❌ 3 regressed benchmarks
✅ 1504 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 30.3 µs 45.2 µs -33.03%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 160.8 µs 197 µs -18.38%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 175.6 µs 211.6 µs -17.02%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/verify-exact-path (134e11c) with develop (340d7be)

Open in CodSpeed

@robert3005 robert3005 changed the title fix issue with FileSystem::glob handling of non-existent files fix issue with FileSystem path handling Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FileSystem::glob with non-glob should verify file exists

3 participants