Skip to content

byte_length() expression#8298

Merged
myrrc merged 1 commit into
developfrom
myrrc/byte-length-expr
Jun 8, 2026
Merged

byte_length() expression#8298
myrrc merged 1 commit into
developfrom
myrrc/byte-length-expr

Conversation

@myrrc

@myrrc myrrc commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

This PR adds byte_length() expression for strings and blobs.
This PR does not allow byte_length pushdown for Duckdb's strlen()
due to SharedArray performance issues (will be added separately).

@myrrc myrrc requested a review from a team June 8, 2026 10:18
@myrrc myrrc added the changelog/feature A new feature label Jun 8, 2026
@myrrc myrrc enabled auto-merge (squash) June 8, 2026 10:19
@myrrc myrrc requested a review from 0ax1 June 8, 2026 10:24
Comment thread vortex-array/src/scalar_fn/fns/byte_length.rs Outdated
Comment thread encodings/fsst/src/compute/byte_length.rs Outdated
@myrrc myrrc force-pushed the myrrc/byte-length-expr branch from de4487a to 5a39298 Compare June 8, 2026 15:20
@myrrc myrrc requested a review from joseph-isaacs June 8, 2026 15:20
@myrrc myrrc force-pushed the myrrc/byte-length-expr branch from 5a39298 to 602f2a4 Compare June 8, 2026 15:26
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
@myrrc myrrc force-pushed the myrrc/byte-length-expr branch from 602f2a4 to 0cb6ecb Compare June 8, 2026 15:34
@codspeed-hq

codspeed-hq Bot commented Jun 8, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 29.54%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 3 improved benchmarks
✅ 1510 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 46.6 µs 31.8 µs +46.85%
Simulation chunked_varbinview_canonical_into[(1000, 10)] 198.2 µs 161.8 µs +22.54%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 213.7 µs 176.9 µs +20.8%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing myrrc/byte-length-expr (0cb6ecb) with develop (5e3aedb)

Open in CodSpeed

@myrrc myrrc merged commit d2d2e29 into develop Jun 8, 2026
86 of 87 checks passed
@myrrc myrrc deleted the myrrc/byte-length-expr branch June 8, 2026 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants