Skip to content

Wrap object stores in python with Compat layer#8316

Merged
robert3005 merged 2 commits into
developfrom
rk/python-reactor
Jun 9, 2026
Merged

Wrap object stores in python with Compat layer#8316
robert3005 merged 2 commits into
developfrom
rk/python-reactor

Conversation

@robert3005

@robert3005 robert3005 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

object_store requires tokio, Compat makes sure all object store futures are run
on tokio runtime

fix #8279

@robert3005 robert3005 requested review from a team and AdamGS June 9, 2026 14:16
Signed-off-by: Robert Kruszewski <github@robertk.io>
Signed-off-by: Robert Kruszewski <github@robertk.io>
@robert3005 robert3005 added the changelog/fix A bug fix label Jun 9, 2026
@robert3005 robert3005 force-pushed the rk/python-reactor branch from 3d08049 to 415a8c9 Compare June 9, 2026 14:26
@robert3005 robert3005 enabled auto-merge (squash) June 9, 2026 14:26
@codspeed-hq

codspeed-hq Bot commented Jun 9, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
❌ 7 regressed benchmarks
✅ 1507 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation bitwise_not_vortex_buffer_mut[128] 216.9 ns 275.3 ns -21.19%
Simulation bitwise_not_vortex_buffer_mut[1024] 278.6 ns 336.9 ns -17.31%
Simulation chunked_varbinview_opt_canonical_into[(1000, 10)] 191.4 µs 227.9 µs -16.01%
Simulation chunked_varbinview_opt_into_canonical[(1000, 10)] 205.7 µs 242.1 µs -15.03%
Simulation decompress_rd[f32, (100000, 0.0)] 499.1 µs 586.4 µs -14.89%
Simulation bitwise_not_vortex_buffer_mut[2048] 342.2 ns 400.6 ns -14.56%
Simulation decompress_rd[f64, (100000, 0.0)] 845.5 µs 981.6 µs -13.86%
Simulation chunked_bool_canonical_into[(1000, 10)] 46.9 µs 32 µs +46.78%
Simulation chunked_varbinview_canonical_into[(100, 100)] 311.3 µs 276.2 µs +12.72%
Simulation chunked_varbinview_into_canonical[(100, 100)] 363.2 µs 328.3 µs +10.64%
Simulation decompress_rd[f64, (100000, 0.01)] 981.3 µs 889.3 µs +10.35%
Simulation decompress_rd[f64, (100000, 0.1)] 981.2 µs 889.2 µs +10.35%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing rk/python-reactor (415a8c9) with develop (998bc65)

Open in CodSpeed

@robert3005 robert3005 merged commit 3e68153 into develop Jun 9, 2026
61 of 62 checks passed
@robert3005 robert3005 deleted the rk/python-reactor branch June 9, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/fix A bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] Panic: "there is no reactor running" when writing to S3 from non-Tokio threads (e.g., Ray Workers)

2 participants