Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Merge QDMEwald #444

Merged
merged 55 commits into from
May 7, 2020
Merged

Merge QDMEwald #444

merged 55 commits into from
May 7, 2020

Conversation

junghans
Copy link
Member

@junghans junghans commented May 6, 2020

To Do:

  • add comment to NOTICE file
  • add copyright header to new files

NOT To Do (in this PR):

  • fix CMake
  • integrate with CI

@ghost
Copy link

ghost commented May 6, 2020

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@@ -0,0 +1,204 @@
/*
* Copyright 2019 Juelich Supercomputing Centre
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhalver is that what you need?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright 2019 Forschungszentrum Juelich GmbH, Germany

It needs to mention the research center itself, not the institute, usually we mention the authors themselves in it, but I am not sure if it is required.

@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #444   +/-   ##
======================================
  Coverage    63.3%   63.3%           
======================================
  Files         279     279           
  Lines       22788   22788           
======================================
  Hits        14437   14437           
  Misses       8351    8351           
Flag Coverage Δ
#gcc 63.3% <0.0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497cd8f...497cd8f. Read the comment docs.

NOTICE Show resolved Hide resolved
Copy link
Member

@JensWehner JensWehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with it. If all legal problems are resolved. @baumeier is the guardian for that right?

@junghans
Copy link
Member Author

junghans commented May 7, 2020

@baumeier @rhalver please approve.

@junghans junghans merged commit 8c61789 into master May 7, 2020
@junghans junghans deleted the QDMEwald branch May 7, 2020 12:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants