Fixed tiny problem in assert - it was throwing errors for me until this fix #167

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
@uberbrady

On the assertion side - when things are going wrong we can't assume that the 'message' will be a valid string. It might not be. Or might not be defined. Either way, as opposed to throwing errors at 'assert', we should at least allow whatever message we do have to be displayed.

uberbrady added some commits Dec 13, 2011

If message is not a string this doesn't work.
On the assertion side - when things are going wrong we can't assume that the 'message' will be a valid string. It might not be. Or might not be defined. Either way, as opposed to throwing errors at 'assert', we should at least allow whatever message we do have to be displayed.
@mmalecki

This comment has been minimized.

Show comment Hide comment
@mmalecki

mmalecki May 24, 2013

Contributor

I'm curious, what errors was it throwing?

Contributor

mmalecki commented May 24, 2013

I'm curious, what errors was it throwing?

@indexzero

This comment has been minimized.

Show comment Hide comment
@indexzero

indexzero Nov 4, 2014

Owner

Closing for lack of follow-up.

Owner

indexzero commented Nov 4, 2014

Closing for lack of follow-up.

@indexzero indexzero closed this Nov 4, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment