Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Prevent assert in topics #203
Users should not use asserts in topics.
Before the following test fails with a strange message, at the wrong assert :
The message :
Now it fails with a warning :
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
The strange output in Filirom's example comes because vows currently pushes a null onto the arguments that it sends to the vow with if you have suite.options.error set to true and more than one input parameter to the vow. So the error is going to be the second argument, and the first argument is going to be null. This is what really needs to be fixed. Once that is fixed, the test would error with an assertion error instead of giving the weird output.