Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Add a test to be run manually to see if vows recognizes filenames that start with a c. #249

Closed
wants to merge 1 commit into from

3 participants

@shane-tomlinson

to run the test, go to the test directory and run:

node ../bin/vows c-filename-test.js

issue #248

@shane-tomlinson shane-tomlinson Add a test to be run manually to see if vows recognizes filenames tha…
…t start with a c.

to run the test, go to the test directory and run:

node ../bin/vows c-filename-test.js
bd3ec37
@JerrySievert

249 or 250?

@shane-tomlinson

@JerrySievert - The original issue this PR addresses is #248. I was unsure of how to go about correctly doing the tests for this PR because test path names (including any directories) must begin with a c or C for the failure to manifest. I am assuming the c/C check is to address the root directory on Windows. If this is the case, it may make more sense to ditch the check for c/C and instead check for the existence of any letter followed by a :

@indexzero
Owner

Fixed in #251

@indexzero indexzero closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 20, 2012
  1. @shane-tomlinson

    Add a test to be run manually to see if vows recognizes filenames tha…

    shane-tomlinson authored
    …t start with a c.
    
    to run the test, go to the test directory and run:
    
    node ../bin/vows c-filename-test.js
This page is out of date. Refresh to see the latest.
Showing with 16 additions and 1 deletion.
  1. +1 −1  bin/vows
  2. +15 −0 test/c-filename-test.js
View
2  bin/vows
@@ -257,7 +257,7 @@ if (! options.watch) {
// add full path if necessary
files = args.map(function (a) {
- return (!a.match(/^[\/|c|C]/))
+ return (!a.match(/^\//) && !a.match(/^[cC]:/))
? path.join(process.cwd(), a)
: a;
});
View
15 test/c-filename-test.js
@@ -0,0 +1,15 @@
+var vows = require('../lib/vows'),
+ assert = require('assert');
+
+vows.describe('vows/c-file-test').addBatch({
+ 'if this test runs': {
+ topic: function() {
+ return true;
+ },
+
+ 'we are happy': function() {
+ assert.ok(true);
+ }
+ }
+}).export(module);
+
Something went wrong with that request. Please try again.