Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame expressions fix #1644

Merged
merged 2 commits into from Mar 18, 2022
Merged

Frame expressions fix #1644

merged 2 commits into from Mar 18, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Mar 17, 2022

Fixes a bug that prevented frames from being attached to video collections when aggregating expressions like the following:

values = dataset.values((F("field") > 0) | (F("frames").length() > 10))

that involve both sample-level and frame-level fields.

A unit test is added to verify correct behavior going forward.

@brimoor brimoor added the bug Bug fixes label Mar 17, 2022
@brimoor brimoor requested a review from a team March 17, 2022 03:05
@brimoor brimoor self-assigned this Mar 17, 2022
benjaminpkane
benjaminpkane approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit 5ab7503 into develop Mar 18, 2022
@brimoor brimoor deleted the expr-fix branch March 18, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@brimoor brimoor

Labels
bug Bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brimoor @benjaminpkane