Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jit urls reverse compatibility #26

Merged
merged 8 commits into from Feb 10, 2020
Merged

Jit urls reverse compatibility #26

merged 8 commits into from Feb 10, 2020

Conversation

@MikeJeffers
Copy link

MikeJeffers commented Feb 6, 2020

Provide fallback to original urls in task.json in case Platform API is not of a version featuring these urls, or the Platform is down, times-out, or returns an error on these routes for w/e reason.

@MikeJeffers MikeJeffers requested review from lethosor, brimoor and voxel51/voxel51-product-team Feb 6, 2020
@MikeJeffers MikeJeffers self-assigned this Feb 6, 2020
voxel51/platform/api.py Outdated Show resolved Hide resolved
voxel51/platform/api.py Outdated Show resolved Hide resolved
@MikeJeffers MikeJeffers requested review from lethosor and voxel51/voxel51-product-team Feb 6, 2020
Copy link
Contributor

lethosor left a comment

Works with platform-demo

url_type (str): one of "status", "log", or "output"
Returns:
a RemotePathConfig object
'''
endpoint = self.base_url + "/jobs/" + job_id + "/url/" + url_type
endpoint = \

This comment has been minimized.

Copy link
@lethosor

lethosor Feb 10, 2020

Contributor

I think our style is to use parentheses for this

@@ -926,7 +929,7 @@ def fail_epically(logfile_path=None):
# Try to upload the logfile, if requested
if logfile_path:
logfile_url = os.environ[voxc.LOGFILE_SIGNED_URL_ENV_VAR]
logfile = RemotePathConfig.from_signed_url(logfile_url)
logfile = voxu.RemotePathConfig.from_signed_url(logfile_url)

This comment has been minimized.

Copy link
@lethosor

lethosor Feb 10, 2020

Contributor

Good catch

@MikeJeffers MikeJeffers merged commit 08c4d28 into jit-urls Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.