Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong slope force calculation for flipped vehicles #890

Closed
xmnovotny opened this issue Aug 24, 2021 · 2 comments
Closed

Wrong slope force calculation for flipped vehicles #890

xmnovotny opened this issue Aug 24, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@xmnovotny
Copy link

When vehicle is flipped, slope force (and acceleration/power needed) is calculated as on opposite direction - going downhill will slow down the vehicle and vice versa.

Steps to reproduce
Build long slope, long doubleheaded train and observe speed, acceleration and power needed for going uphill and downhill after whole train reverse its direction.

Build version
0.86.1.0

Platform
Windows 10

Reproducibility
Everytime

Fix
In function Vehicle.GetSlopeForce multiply whole result by -1 when Vehicle.IsFlipped and subresults by -1 when VehicleUnit.IsFlipped

@victorleblais victorleblais added the bug Something isn't working label Sep 9, 2021
@andrewpey
Copy link
Collaborator

Thanks, will be fixed with 0.87.

@andrewpey
Copy link
Collaborator

The fix is live on the beta branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants