New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block lighting is not properly calculated #41

Open
stayandwait opened this Issue Oct 8, 2016 · 7 comments

Comments

Projects
None yet
6 participants
@stayandwait

stayandwait commented Oct 8, 2016

When you place down torches at night, then reopen your world the torches don't give their light.

The way I tested this

  • Dig under ground, make sure it's dark.
  • Place down torch.
  • Reopen world and the torch has no lighting.

2016-10-08_1931

2016-10-08_1933

@minecrafter

This comment has been minimized.

Member

minecrafter commented Oct 9, 2016

Not currently implemented. If you'd like to help, please feel free to open a pull request.

@minecrafter minecrafter self-assigned this Oct 9, 2016

@minecrafter minecrafter added this to the 0.1 (Breeze) milestone Oct 9, 2016

@minecrafter minecrafter removed their assignment Oct 9, 2016

@minecrafter minecrafter changed the title from Torches don't give light after reopening the world to Block lighting is not properly calculated Oct 29, 2016

@minecrafter

This comment has been minimized.

Member

minecrafter commented Nov 23, 2016

I tried to work on this a little bit by porting some code from PocketMine. It doesn't work too well, but I will investigate this later.

@hugmanrique

This comment has been minimized.

hugmanrique commented Nov 23, 2016

It's stupid that the lighting levels are calculated server side instead of client side

@MiniDigger

This comment has been minimized.

MiniDigger commented Nov 23, 2016

@hugmanrique the server needs to do that since he also needs to handle spawns based on the lighting level ;)

@Tee7even

This comment has been minimized.

Member

Tee7even commented Nov 24, 2016

I tried to work on this a little bit by porting some code from PocketMine. It doesn't work too well, but I will investigate this later.

PM is not a good source of... anything (imo). Wasn't @NiclasOlofsson working on lighting lately?

@NiclasOlofsson

This comment has been minimized.

NiclasOlofsson commented Nov 24, 2016

My focus has been on recalculating it when MiNET load Anvil maps with faulty light because of cut and paste with WorldEdit and similar tools. It does implement addition of light-sources runtime, but that part is low-priority for me (I've only done add of lightsource, not remove) because this is a non-PVP feature. Also, porting an existing implementation is really not a good option here, because you need to really tailor it to the code at hand because of performance. So you actually really need to understand how it works. And why it works.

@minecrafter

This comment has been minimized.

Member

minecrafter commented Nov 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment