New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds translation support using I18n-js #391

Merged
merged 27 commits into from Jan 25, 2017

Conversation

Projects
None yet
3 participants
@pardo-bsso
Contributor

pardo-bsso commented Dec 16, 2016

Hello,

this is a follow up of #390 , I believe I didn't leave out any text.

Thanks.

@VOX-OPS

This comment has been minimized.

Show comment
Hide comment
@VOX-OPS

VOX-OPS Dec 16, 2016

Can one of the admins verify this pull request? Respond with 'test this please' to trigger a build.

VOX-OPS commented Dec 16, 2016

Can one of the admins verify this pull request? Respond with 'test this please' to trigger a build.

@pardo-bsso

This comment has been minimized.

Show comment
Hide comment
@pardo-bsso

pardo-bsso Dec 16, 2016

Contributor

bummer.
I can't see why the build failed but I'm more than happy to help with that.

Contributor

pardo-bsso commented Dec 16, 2016

bummer.
I can't see why the build failed but I'm more than happy to help with that.

@pardo-bsso

This comment has been minimized.

Show comment
Hide comment
@pardo-bsso

pardo-bsso Dec 19, 2016

Contributor

Hi all, please forgive me for being such a bother.
I do not have access to Jenkins in order to see what failed but running the tests here on a clean clone also fails.

@ryanmark , we are really interested in advancing the progress of Autotune, is there anything else we can do to speed up things?

Thanks.

Contributor

pardo-bsso commented Dec 19, 2016

Hi all, please forgive me for being such a bother.
I do not have access to Jenkins in order to see what failed but running the tests here on a clean clone also fails.

@ryanmark , we are really interested in advancing the progress of Autotune, is there anything else we can do to speed up things?

Thanks.

@ryanmark

This comment has been minimized.

Show comment
Hide comment
@ryanmark

ryanmark Dec 19, 2016

Member

.......E........................S...................................................................................SS.Use assert_nil if expecting nil from /app/test/models/autotune/user_test.rb:21:in `block in <class:UserTest>'. This will fail in MT6.
.S......S...............S................

Finished in 83.452811s, 1.9173 runs/s, 10.7486 assertions/s.

  1) Error:
Autotune::BlueprintsControllerTest#test_update_blueprint_repo_url:
NoMethodError: undefined method `each' for nil:NilClass
    /app/app/jobs/autotune/sync_blueprint_job.rb:95:in `perform'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:32:in `block in perform_now'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:329:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:329:in `block (2 levels) in conditional'
    /app/lib/active_job/locking.rb:22:in `call'
    /app/lib/active_job/locking.rb:22:in `block (2 levels) in <module:Locking>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:328:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:328:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/i18n-0.7.0/lib/i18n.rb:257:in `with_locale'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/translation.rb:7:in `block (2 levels) in <module:Translation>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:23:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:23:in `block (4 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `block in instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:22:in `block (3 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `block in tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `block in tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:26:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:19:in `block (2 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_perform_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:31:in `perform_now'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:21:in `execute'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/queue_adapters/test_adapter.rb:35:in `enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:71:in `block in enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:14:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:14:in `block (3 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `block in tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `block in tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:26:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:13:in `block (2 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_enqueue_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:67:in `enqueue'
    /app/lib/active_job/chaining.rb:30:in `enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:17:in `perform_later'
    /app/app/models/autotune/blueprint.rb:88:in `update_repo'
    /app/app/controllers/autotune/blueprints_controller.rb:59:in `update'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/base.rb:198:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/rendering.rb:10:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/callbacks.rb:19:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/rescue.rb:29:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `block in instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.7.1/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/base.rb:137:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionview-4.2.7.1/lib/action_view/rendering.rb:30:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:639:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:67:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:532:in `put'
    /app/test/controllers/autotune/blueprints_controller_test.rb:155:in `block (2 levels) in <class:BlueprintsControllerTest>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:115:in `block in assert_performed_jobs'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:198:in `perform_enqueued_jobs'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:115:in `assert_performed_jobs'
    /app/test/controllers/autotune/blueprints_controller_test.rb:154:in `block in <class:BlueprintsControllerTest>'

160 runs, 897 assertions, 0 failures, 1 errors, 6 skips

You have skipped tests. Run with --verbose for details.
rake aborted!
Command failed with status (1)
/app/vendor/bundle/ruby/2.2.0/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)
Stopping autotunepullrequests_redis_1 ... ```
Member

ryanmark commented Dec 19, 2016


.......E........................S...................................................................................SS.Use assert_nil if expecting nil from /app/test/models/autotune/user_test.rb:21:in `block in <class:UserTest>'. This will fail in MT6.
.S......S...............S................

Finished in 83.452811s, 1.9173 runs/s, 10.7486 assertions/s.

  1) Error:
Autotune::BlueprintsControllerTest#test_update_blueprint_repo_url:
NoMethodError: undefined method `each' for nil:NilClass
    /app/app/jobs/autotune/sync_blueprint_job.rb:95:in `perform'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:32:in `block in perform_now'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:329:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:329:in `block (2 levels) in conditional'
    /app/lib/active_job/locking.rb:22:in `call'
    /app/lib/active_job/locking.rb:22:in `block (2 levels) in <module:Locking>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:328:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:328:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/i18n-0.7.0/lib/i18n.rb:257:in `with_locale'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/translation.rb:7:in `block (2 levels) in <module:Translation>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:23:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:23:in `block (4 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `block in instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:22:in `block (3 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `block in tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `block in tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:26:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:19:in `block (2 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_perform_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:31:in `perform_now'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/execution.rb:21:in `execute'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/queue_adapters/test_adapter.rb:35:in `enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:71:in `block in enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:334:in `block in conditional'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:498:in `block (2 levels) in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:343:in `block (2 levels) in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:14:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:14:in `block (3 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `block in tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `block in tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:26:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/tagged_logging.rb:68:in `tagged'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:43:in `tag_logger'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/logging.rb:13:in `block (2 levels) in <module:Logging>'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `instance_exec'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:441:in `block in make_lambda'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:342:in `block in simple'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:497:in `block in around'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_enqueue_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:67:in `enqueue'
    /app/lib/active_job/chaining.rb:30:in `enqueue'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/enqueuing.rb:17:in `perform_later'
    /app/app/models/autotune/blueprint.rb:88:in `update_repo'
    /app/app/controllers/autotune/blueprints_controller.rb:59:in `update'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/base.rb:198:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/rendering.rb:10:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:117:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:505:in `call'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/callbacks.rb:81:in `run_callbacks'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/callbacks.rb:19:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/rescue.rb:29:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `block in instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/activesupport-4.2.7.1/lib/active_support/notifications.rb:164:in `instrument'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/activerecord-4.2.7.1/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/abstract_controller/base.rb:137:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionview-4.2.7.1/lib/action_view/rendering.rb:30:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:639:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:67:in `process'
    /app/vendor/bundle/ruby/2.2.0/gems/actionpack-4.2.7.1/lib/action_controller/test_case.rb:532:in `put'
    /app/test/controllers/autotune/blueprints_controller_test.rb:155:in `block (2 levels) in <class:BlueprintsControllerTest>'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:115:in `block in assert_performed_jobs'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:198:in `perform_enqueued_jobs'
    /app/vendor/bundle/ruby/2.2.0/gems/activejob-4.2.7.1/lib/active_job/test_helper.rb:115:in `assert_performed_jobs'
    /app/test/controllers/autotune/blueprints_controller_test.rb:154:in `block in <class:BlueprintsControllerTest>'

160 runs, 897 assertions, 0 failures, 1 errors, 6 skips

You have skipped tests. Run with --verbose for details.
rake aborted!
Command failed with status (1)
/app/vendor/bundle/ruby/2.2.0/gems/rake-12.0.0/exe/rake:27:in `<top (required)>'
Tasks: TOP => test
(See full trace by running task with --trace)
Stopping autotunepullrequests_redis_1 ... ```
@ryanmark

This comment has been minimized.

Show comment
Hide comment
@ryanmark

ryanmark Dec 19, 2016

Member

I will try to review this in the next couple days. @kavyasukumar can you also review?

Member

ryanmark commented Dec 19, 2016

I will try to review this in the next couple days. @kavyasukumar can you also review?

@pardo-bsso

This comment has been minimized.

Show comment
Hide comment
@pardo-bsso

pardo-bsso Dec 19, 2016

Contributor

Same happens here.
Thanks for your time.

Contributor

pardo-bsso commented Dec 19, 2016

Same happens here.
Thanks for your time.

@ryanmark

Lets not worry about refactoring to support browserify right now, but i'd like to include all the transitions in this project and not require people to do their own translations.

Show outdated Hide outdated TRANSLATING.md
I18n.defaultLocale = "<%= I18n.default_locale %>";
I18n.locale = "<%= I18n.locale %>";
I18n.fallbacks = true;
</script>

This comment has been minimized.

@ryanmark

ryanmark Dec 21, 2016

Member

So I think this can work for now... but all other javascripts are being handled by node and browserify, so it's possible that this will break our javascript testing rig. There is very little test coverage in that rig currently which is why this will work for now, but it will have to be refactored in the future if we want to add more javascript tests.

@ryanmark

ryanmark Dec 21, 2016

Member

So I think this can work for now... but all other javascripts are being handled by node and browserify, so it's possible that this will break our javascript testing rig. There is very little test coverage in that rig currently which is why this will work for now, but it will have to be refactored in the future if we want to add more javascript tests.

This comment has been minimized.

@pardo-bsso

pardo-bsso Dec 21, 2016

Contributor

Right now I'm not sure I follow how this might break something else but feel free to nudge me in the correct direction.

@pardo-bsso

pardo-bsso Dec 21, 2016

Contributor

Right now I'm not sure I follow how this might break something else but feel free to nudge me in the correct direction.

@@ -0,0 +1,137 @@
en:

This comment has been minimized.

@ryanmark

ryanmark Dec 21, 2016

Member

Can we include the es translations in this file too?

@ryanmark

ryanmark Dec 21, 2016

Member

Can we include the es translations in this file too?

This comment has been minimized.

@pardo-bsso

pardo-bsso Dec 21, 2016

Contributor

Sure!
we have another person doing that, I can update this PR when it's done.

@pardo-bsso

pardo-bsso Dec 21, 2016

Contributor

Sure!
we have another person doing that, I can update this PR when it's done.

@ryanmark ryanmark merged commit a14ece0 into voxmedia:master Jan 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment