(MAINT) Update RHEL support for GCE #1496
Conversation
|
@kevpl Revert all |
|
@kevpl @puppetlabs/beaker can I get another set of eyes on this one? There seems to be a good amount of history in these changes. |
|
@puppetlabs/beaker Can someone let me know what is broken in Jenkins? |
|
@mchllweeks Any updates here? |
Apologies on the long wait here. These changes look good to me
It looks like this needs a rebase & once that's done, we can push it through the automation & get it merged.
trevor-vaughan
force-pushed
the
google_cloud_rhel
branch
from
9603b61
to
e0af28e
Compare
|
@trevor-vaughan huh, it looks like something didn't go through on the rebase? Or perhaps we merged something after the rebase? Still has conflicts |
Updated RHEL tests and support as discovered when testing the GCE patches in beaker-google.
trevor-vaughan
force-pushed
the
google_cloud_rhel
branch
from
e0af28e
to
b14c138
Compare
|
@kevpl So, I've performed the rebase but the spec tests are failing and I don't know why. I think I need some help on this one. |
think I've found the spec failure cause, please checkout my inline comment.
lib/beaker/host_prebuilt_steps.rb
Outdated
| logger.debug(skip_msg) | ||
| unless skip_msg.nil? | ||
| logger.debug( skip_msg ) | ||
| next |
There was a problem hiding this comment.
@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause.
There was a problem hiding this comment.
@kevpl Ah, I see. I won't have time to get to this before Sunday so feel free to just update the PR directly (I have allow maintainers to update) if you want to move it forward.
|
last comment still current |
2 similar comments
|
last comment still current |
|
last comment still current |
|
@kevpl Updated. You were spot on on the code segment. |
|
passed spec testing! these failures are unrelated & I believe I've helped them in another PR (#1546), so I'll re-kick these: retest this please |
|
failures unrelated to changes |
The changelog entry from this PR is old: voxpupuli#1496 This change pulls the changelog entry from back then into the now [skip ci]
Updated RHEL tests and suppoort as discovered when testing the GCE
patches in beaker-google.