(MAINT) add rsync backoff for testing #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchllweeks
approved these changes
Oct 8, 2018
Before, we would have a number of tests fail where it was caused by some connection error that if we had run it again, it probably would not be a problem. This change allows these calls to be made with backoffs so that the tests will be a little slower occasionally, but much more resilient to network issues
smcelmurry
approved these changes
Oct 15, 2018
kevpl
added a commit
to kevpl/beaker
that referenced
this issue
Oct 17, 2018
In my previous work on this: voxpupuli#1546 I took care of the cases where the method returned successfully but the issue we are seeing in CI is where exceptions are being thrown by the Host#do_rsync_to method. These changes take the exceptions into account, allowing them to be other cases that end similarly to the first, where we just continue backoff execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Before, we would have a number of tests fail where
it was caused by some connection error that if we
had run it again, it probably would not be a problem.
This change allows these calls to be made with backoffs
so that the tests will be a little slower occasionally,
but much more resilient to network issues