Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting an invalid proxy_server parameter should return a more helpful error message. #220

Closed
Renelast opened this issue Sep 20, 2016 · 0 comments

Comments

@Renelast
Copy link

Renelast commented Sep 20, 2016

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.X
  • Ruby: N/A
  • Distribution:N/A
  • Module version: v1.1.2

How to reproduce (e.g Puppet code you use)

Specify an archive resource with an proxy_server parameter set without an httpp(s) prefix (145.222.145.222:3128 for example).
e.g.
archive { 'fake': proxy_server => '145.222.145.222:3128', }

What are you seeing

Puppetrun fails right after receiving catalog with error 'bad URI(is not URI?): 145.222.145.222:3128'

What behavior did you expect instead

An error that points to what resource caused this instead of this (too) generic error.

Output log

bad URI(is not URI?): 145.222.145.222:3128

Any additional information you'd like to impart

I guess this is caused by the URI call on https://github.com/voxpupuli/puppet-archive/blob/master/lib/puppet/type/archive.rb#L251 which is un-catched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant