Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support puppet:/// urls or edit readme? #283

Closed
7yl4r opened this issue May 17, 2017 · 12 comments
Closed

Support puppet:/// urls or edit readme? #283

7yl4r opened this issue May 17, 2017 · 12 comments

Comments

@7yl4r
Copy link

7yl4r commented May 17, 2017

What are you seeing

The readme provides an example using a "puppet:/// style url which is not currently supported."

What behaviour did you expect instead

Why is this included if it is not supported? Is it planned for implementation soon?

Any additional information you'd like to impart

I think I may just be confused here, but perhaps a quick change to the readme would be helpful. Is #77 an implementation of this functionality but the readme was overlooked?

@7yl4r 7yl4r changed the title Support puppet:/// urls or remove from readme? Support puppet:/// urls or edit readme? May 17, 2017
@7yl4r
Copy link
Author

7yl4r commented May 17, 2017

After working with this a bit I've found that the readme is describing a workaround. Although this is clear to me now, my initial confusion may indicate that the readme should clarify this point a bit.

Additionally: is there an open feature request for supporting puppet:// urls without the workaround?

@alexjfisher
Copy link
Member

See #270

@alexjfisher
Copy link
Member

@7yl4r Sorry for the brevity earlier (I didn't realise my train was pulling into the station!).

Being able to use puppet:/// URLs is a feature we're hoping to merge 'real soon now'.

@7yl4r
Copy link
Author

7yl4r commented May 17, 2017

I figured there must be something ongoing somewhere, but couldn't find it this morning. Thanks!

@hajee
Copy link
Contributor

hajee commented Aug 12, 2017

I think this one can be closed, since #270 has been merged and provides just this.

@igalic
Copy link
Contributor

igalic commented Aug 14, 2017

do we have a version with this feature released yet?

@alexjfisher
Copy link
Member

@igalic Not yet, but I think we should go ahead with a release now.

@hajee
Copy link
Contributor

hajee commented Aug 18, 2017

So what are the steps and the timeline you have in mind? Can I assist somehow?

@igalic
Copy link
Contributor

igalic commented Aug 21, 2017

@alexjfisher
Copy link
Member

@hajee I made a start by doing a modulesync, but then ran out of time before going on holiday.
You could create a release PR but normally the changelog will need improving by updating various issues and PRs with the correct labels etc. Do you want to open the release PR anyway to see how we're looking? I've only got my phone with me, so can't be much more help until I return home on Friday.

@hajee
Copy link
Contributor

hajee commented Aug 22, 2017

I'll see what I can do.

@nanliu
Copy link
Contributor

nanliu commented Sep 9, 2017

Closed since v2.0.0 is released with puppet:///

@nanliu nanliu closed this as completed Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants