Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: make password sensitive and hide on fail #397

Closed
Joris29 opened this issue Jan 23, 2020 · 0 comments · Fixed by #399
Closed

Feature request: make password sensitive and hide on fail #397

Joris29 opened this issue Jan 23, 2020 · 0 comments · Fixed by #399

Comments

@Joris29
Copy link

Joris29 commented Jan 23, 2020

Would it be possible to hide the password when the archive resource fails?

Ex. change from 'absent' to 'present' failed: Execution of '/usr/bin/curl https://example.org/test.zip -o /tmp/test.zip_20200122-15071-xnnt9z -fsSLg --max-redirs 5 --user test:test' returned 22: curl: (22) The requested URL returned error: 404 Not Found

Something like this:
change from 'absent' to 'present' failed: Execution of '/usr/bin/curl https://example.org/test.zip -o /tmp/test.zip_20200122-15071-xnnt9z -fsSLg --max-redirs 5 --user test:Sensitive [value redacted]' returned 22: curl: (22) The requested URL returned error: 404 Not Found
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Jan 26, 2020
@alexjfisher
Use curl netrc file instead of --user
c206747 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
@alexjfisher alexjfisher mentioned this issue Jan 26, 2020
Merged
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Jan 27, 2020
@alexjfisher
Use curl netrc file instead of --user
f91ef8f 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Apr 2, 2020
@alexjfisher
Use curl netrc file instead of --user
6dabb63 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Apr 2, 2020
@alexjfisher
Use curl netrc file instead of --user
98ad0c8 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Apr 2, 2020
@alexjfisher
Use curl netrc file instead of --user
7fd3572 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
alexjfisher added a commit to alexjfisher/puppet-archive that referenced this issue Apr 2, 2020
@alexjfisher
Use curl netrc file instead of --user
dfa62f0 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
@ekohl ekohl closed this as completed in #399 Apr 2, 2020
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this issue Mar 26, 2021
@alexjfisher
Use curl netrc file instead of --user
d37ee06 
This stops credentials appearing in the process list and failed
downloads won't result in the credentials being logged in puppet reports
and agent log output.

Fixes voxpupuli#397
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use curl netrc file instead of --user alexjfisher/puppet-archive
1 participant
@Joris29