Support fetching latest SNAPSHOT artifacts #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
commented
Jan 4, 2018
| @@ -72,24 +72,43 @@ | |||
| } | |||
|
|
|||
| if $url { | |||
| $file_url = $url | |||
| $sha1_url = regsubst($url, '/artifactory/', '/artifactory/api/storage/') | |||
| $maven2_data = archive::parse_artifactory_url($url) | |||
There was a problem hiding this comment.
if parse_artifactory_url fails to parse the url, it returns nil
alexjfisher
commented
Jan 4, 2018
| $file_url = $url | ||
| $sha1_url = regsubst($url, '/artifactory/', '/artifactory/api/storage/') | ||
| $maven2_data = archive::parse_artifactory_url($url) | ||
| if $maven2_data and $maven2_data['folder_iteg_rev'] == 'SNAPSHOT'{ |
There was a problem hiding this comment.
so if maven2_data is nil, the new code won't be run.
bastelfreak
approved these changes
Jan 4, 2018
|
looks good to me. I would like to merge & release this after a rebase |
alexjfisher
force-pushed
the
artifactory_snapshots
branch
from
fe73c56
to
2358b23
Compare
|
I'd be fine letting it sit in master for a couple of weeks. There's nothing else waiting for a release I don't think. |
alexjfisher
added
enhancement
alexjfisher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC/WIP: DO NOT MERGE
This works for me and fixes
#282
Feedback and some volunteers to test welcome.