Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log actual and expected checksums on mismatch #305

Merged

Conversation

jeffmccune
Copy link
Contributor

@jeffmccune jeffmccune commented Nov 20, 2017

Without this patch, updating Jenkins plugins is difficult because it
isn't clear what the actual checksum of the downloaded package is. The
end user may discover the checksum by running puppet in debug mode,
discovering the curl command used to download the jenkins plugin, run
the command manually, then compute the checksum manually.

This patch helps the user by displaying the actual and expected
checksums when comparing them. This allows the user to copy and paste
the actual checksum when updating hiera with the expected checksum.

Example

Error: Download file checksum mismatch (expected: 67051eb6df486e3639ad19bd9a46f43d19aec506 actual: beecec5ab3321c68ad5cce76ceacc14357c4da88)
Error: /Stage[main]/Jenkins::Plugins/Jenkins::Plugin[pipeline-model-api]/Archive[pipeline-model-api.hpi]/ensure: change from absent to present failed: Download file checksum
 mismatch (expected: 67051eb6df486e3639ad19bd9a46f43d19aec506 actual: beecec5ab3321c68ad5cce76ceacc14357c4da88)

Without this patch, updating Jenkins plugins is difficult because it
isn't clear what the actual checksum of the downloaded package is.  The
end user may discover the checksum by running puppet in debug mode,
discovering the curl command used to download the jenkins plugin, run
the command manually, then compute the checksum manually.

This patch helps the user by displaying the actual and expected
checksums when comparing them.  This allows the user to copy and paste
the actual checksum when updating hiera with the expected checksum.
@bastelfreak
Copy link
Member

Thanks for the patch @jeffmccune!

@bastelfreak bastelfreak merged commit bdbfb50 into voxpupuli:master Nov 21, 2017
@ghoneycutt
Copy link
Member

Thanks @bastelfreak !

Could you let us know when you've tagged a new release that contains this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants