Log actual and expected checksums on mismatch #305
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch, updating Jenkins plugins is difficult because it
isn't clear what the actual checksum of the downloaded package is. The
end user may discover the checksum by running puppet in debug mode,
discovering the curl command used to download the jenkins plugin, run
the command manually, then compute the checksum manually.
This patch helps the user by displaying the actual and expected
checksums when comparing them. This allows the user to copy and paste
the actual checksum when updating hiera with the expected checksum.
Example