Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not escape path on windows for unzip command #344

Merged
merged 4 commits into from
Jul 31, 2018
Merged

do not escape path on windows for unzip command #344

merged 4 commits into from
Jul 31, 2018

Conversation

qs5779
Copy link
Contributor

@qs5779 qs5779 commented Jul 19, 2018

No description provided.

@bastelfreak
Copy link
Member

Hi @qs5779, thanks for opening up this PR. Can you please rebase after #345 got merged?

@qs5779
Copy link
Contributor Author

qs5779 commented Jul 23, 2018

rebased per request

@bastelfreak
Copy link
Member

Hi @qs5779, can you take a look at the failing travis jobs? Please also have a look at the used email address in your commits. It isn't associated with your github account.

@bastelfreak bastelfreak added tests-fail needs-work not ready to merge just yet bug Something isn't working labels Jul 29, 2018
@qs5779
Copy link
Contributor Author

qs5779 commented Jul 30, 2018

I think I have my email address in all my global git configs, I have corrected one of the failing tests and working on the others, be patient please.

@qs5779
Copy link
Contributor Author

qs5779 commented Jul 31, 2018

I am an ancient code warrior, but I learned some things with this one.

@bastelfreak bastelfreak removed needs-work not ready to merge just yet tests-fail labels Jul 31, 2018
@bastelfreak
Copy link
Member

Thanks for the work @qs5779 !

@bastelfreak bastelfreak merged commit 94682cd into voxpupuli:master Jul 31, 2018
cegeka-jenkins pushed a commit to cegeka/puppet-archive that referenced this pull request Mar 26, 2021
do not escape path on windows for unzip command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants