Fallback to PowerShell for zip files on Windows #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffWilliams
force-pushed
the
powerunzip
branch
from
5d72027
to
df3c9a4
Compare
For Windows since 2012, it is possible to extract zip files (only) using `System.IO.Compression.FileSystem`. For systems where 7zip is not available, use an inline powershell script to perform the extact. 7zip will still be used in preference, if available.
GeoffWilliams
force-pushed
the
powerunzip
branch
from
df3c9a4
to
9b808ad
Compare
|
Thanks for the PR @GeoffWilliams ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-archive
that referenced
this pull request
Mar 26, 2021
Fallback to PowerShell for zip files on Windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most users on Windows are going to be using zip files and might not be able to easily install 7zip, how about this approach for using PowerShell/.net built-in support to for zip files to do the extract when there is no 7zip rather then failing?