Convert assemble_nexus_url to modern API
#390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the easy bit of #329 |
ekohl
approved these changes
Dec 6, 2019
Depends on whether you think the original function was ever considered public. I think probably not. |
|
Probably not |
bastelfreak
approved these changes
Dec 6, 2019
alexjfisher
commented
Dec 6, 2019
| # The assembled URL | ||
| dispatch :default_impl do | ||
| param 'Stdlib::HTTPUrl', :nexus_url | ||
| param 'Hash', :params |
There was a problem hiding this comment.
I should probably put the return type in here too.
alexjfisher
force-pushed
the
convert_assemble_nexus_url
branch
from
d15a402
to
015922b
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-archive
that referenced
this pull request
Mar 26, 2021
…xus_url Convert `assemble_nexus_url` to modern API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.