Use relative_require in artifactory functions
#391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't seem to have been neccessary for all users and probably depends on how puppetserver has `ruby-load-path` configured. See https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=224547&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-224547 Requiring the library using an absolute path should help https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=352751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-352751 Note, any changes to util.rb will still result in horrible environment isolation issues. A full fix would involve implementing @trevor-vaughan's complete metaprogramming solution documented here. https://www.onyxpoint.com/fixing-the-client-side-of-multi-tenancy-in-the-puppet-server util.rb is somewhat more complicated than the example demonstrated, so I've left that well alone for now. Fixes voxpupuli#320
alexjfisher
commented
Dec 6, 2019
| @@ -14,7 +14,7 @@ def self.content(url, options = {}) | |||
| end | |||
|
|
|||
| # | |||
| # This allows you to use a puppet syntax for a file and return it's content. | |||
| # This allows you to use a puppet syntax for a file and return its content. | |||
There was a problem hiding this comment.
Couldn't help myself! ;)
ekohl
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to have been neccessary for all users and probably
depends on how puppetserver has
ruby-load-pathconfigured.See https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=224547&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-224547
Requiring the library using an absolute path should help
https://tickets.puppetlabs.com/browse/SERVER-973?focusedCommentId=352751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-352751
Note, any changes to util.rb will still result in horrible environment
isolation issues. A full fix would involve implementing
@trevor-vaughan's complete metaprogramming solution documented here.
https://www.onyxpoint.com/fixing-the-client-side-of-multi-tenancy-in-the-puppet-server
util.rb is somewhat more complicated than the example demonstrated, so
I've left that well alone for now.
Fixes #320