Convert go_md5 function to modern API
#392
Conversation
| # @summary | ||
| # Retrieves and returns specific file's md5 from GoCD server md5 checksum file | ||
| # @api private | ||
| # @see http://www.thoughtworks.com/products/docs/go/12.4/help/Artifacts_API.html |
There was a problem hiding this comment.
I took this 'broken' link directly from the old function. I was going to update with eg. https://api.gocd.org/current/#get-artifact-file, but that says Available since v14.3.0. This is why I suspect this function (and archive::go) might be outdated and of limited value until a GoCD user comes along and fixes them up.
alexjfisher
force-pushed
the
convert_go_md5_function
branch
from
c3794b1
to
12da972
Compare
I'm not actually sure if anybody uses this or whether this works with recent GoCD servers. It's pretty easy to port to the new puppet function API though.
alexjfisher
force-pushed
the
convert_go_md5_function
branch
from
12da972
to
41cc39b
Compare
| uri = URI(url) | ||
| PuppetX::Bodeco::Util.stubs(:content).with(uri, username: 'user', password: 'pass').returns(example_md5) | ||
| is_expected.to run.with_params('user', 'pass', 'filea', url).and_return('283158c7da8c0ada74502794fa8745eb') | ||
| end |
There was a problem hiding this comment.
Consider adding a test that demonstrates the error state and hits the raise in the function.
There was a problem hiding this comment.
I was aiming to limit my changes to just converting the function, but actually, I think you're right that the error handling code is broken. Fixing that up should be simple enough.
|
Suggest adding an acceptance test that pulls a static file, such as from VP's website, and shows that the md5 is as expected. |
At the moment this module hasn't got any acceptance tests. This function probably isn't where I'd start. PRs welcome of course! :) |
I'm not actually sure if anybody uses this or whether this works with
recent GoCD servers. It's pretty easy to port to the new puppet
function API though.