Clean up temporary files when checksums don't match #412
Conversation
Noticed that the archive module was leaving behind quite a few files in /tmp when there were checksum mismatches. This ensures that the temporary files will be cleaned up before throwing an error.
benridley
changed the title
|
@benridley Good idea! Could you please add a test so this can be merged. Acceptance tests are preferred. You can cause the situation where a tmp file would normally be left then check the existence of the file to show that it is not there. |
|
Hey @ghoneycutt, happy to add an acceptance test to get this merged. I'm not really too familiar with Ruby testing. Is RSpec the right path to go down here or is that strictly unit testing? Cheers! |
|
Dear @benridley, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
This module does not have acceptance tests setup and the errors are totally unrelated to this so merging. |
would this module benefit from acceptance tests? |
|
Ha, it sure would! Are you volunteering :) |
Clean up temporary files when checksums don't match
| @@ -191,6 +191,7 @@ def transfer_download(archive_filepath) | |||
| archive = PuppetX::Bodeco::Archive.new(temppath) | |||
| actual_checksum = archive.checksum(resource[:checksum_type]) | |||
| if actual_checksum != checksum | |||
| destroy(temppath) | |||
There was a problem hiding this comment.
destroy doesn’t take any arguments...
Fixed in #443
Noticed that the archive module was leaving behind quite a few files in /tmp when there were checksum mismatches.
This ensures that the temporary files will be cleaned up before throwing an error.
Pull Request (PR) description
This pull request removes the temporary files created by the archive module if the checksum fails to match. Previously, the module would throw an error and leave the temporary file in /tmp.