Add temp_dir parameter to archive::nexus
#415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igalic
suggested changes
Aug 18, 2020
igalic
suggested changes
Aug 19, 2020
There was a problem hiding this comment.
please add the new parameter to the tests here
https://github.com/voxpupuli/puppet-archive/blob/master/spec/defines/nexus_spec.rb
Is it Ok if I'll add in 'nexus archive with overwritten parameters' part and won't create a new code block? |
|
yes |
alexjfisher
reviewed
Aug 20, 2020
alexjfisher
changed the title
temp_dir parameter to archive::nexus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues