Add initial support for gsutil and pulling from Google Storage buckets #421
Conversation
|
@j0sh3rs thanks for the PR. Can you add some unit tests for this change? |
|
@bastelfreak -- Added some tests, let me know if they're up to par! I basically copied the ruby spec and modified it for gsutil. |
There was a problem hiding this comment.
looks good to me, but I'm not a types/provider expert. @alexjfisher or @ekohl would you like to review as well?
| @@ -66,4 +69,32 @@ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if $gsutil_install { | |||
| # TODO: Windows support. | |||
There was a problem hiding this comment.
https://cloud.google.com/storage/docs/gsutil_install?hl=en#windows
installation on windows uses the same archive, but different paths
and python installation on windows isn't guaranteed, so that's another issue, and so might the execution be
however, given that this thing requires python 2.7, which is EOL, a safe execution on any platform is not guaranteed
There was a problem hiding this comment.
There was a problem hiding this comment.
would be cool if they updated their documentation
There was a problem hiding this comment.
Hi @igalic -- totally agreed that the doc on Google's side could use some work (this is seemingly systemic for them). Are we considering this a blocker for acceptance of this PR, or is there something additional I can provide to help shepherd this through?
Thanks very much for the review.
There was a problem hiding this comment.
it was a remark on my approving of this pr
so i think with enough eyes on this now, we can hit the merge button and see what happens after that
Add initial support for gsutil and pulling from Google Storage buckets
Pull Request (PR) description
This PR adds support in the archive module for pulling assets from Google Storage buckets by way of gsutil
This Pull Request (PR) fixes the following issues
No Issues were filed prior to this PR.