Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass over credentials in archive::artifactory #433

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

jramosf
Copy link
Contributor

@jramosf jramosf commented Feb 9, 2021

This change allows passing optional credentials to the archive resource from archive::artifactory.

This change allows passing optional credentials to the `archive` resource from `archive::artifactory`.
@jramosf
Copy link
Contributor Author

jramosf commented Feb 15, 2021

Hello @kenyon ,

You added the needs-tests label but I see #430 is already testing the password functionality of archive, and this is just passing over the parameters to that same function.

Cheers,

@kenyon kenyon merged commit 6df1239 into voxpupuli:master Feb 15, 2021
@jramosf jramosf deleted the patch-1 branch February 16, 2021 08:44
@Rwwn
Copy link

Rwwn commented Jun 4, 2021

This doesn't work for me because the artifactory_checksum function also requires separate username/password authentication, which isn't covered in this PR. Providing the username and password still results in a forbidden error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants