Produce a better error for the puppet downloader when file not found #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of Puppet raise the error Puppet::HTTP::RouteError when the file is not found. This resulted not only in a misleading error but also an error without the original url. This commit changes this. It catches the error and produces an error with the url in it. Unfortunately, the original misleading error is still produces, so we try to elaborate a bit in the error we produce.
|
Is there an ETA when there is time to look at this PR? |
No, just when one of us @voxpupuli volunteers gets around to it. 😄 The change seems fine to me, but I don't use this module. |
|
thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of Puppet raise the error Puppet::HTTP::RouteError when the file is not found. This resulted not only in a misleading error but also an error without the original url.
This commit changes this. It catches the error and produces an error with the url in it. Unfortunately, the original misleading error is still produces, so we try to elaborate a bit in the error we produce.