Set optional param to undef to fix failing test (REVERTED IN 6.0.1) #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Holding review & merge while an associated issue is filed and the commit message is updated. |
yachub
force-pushed
the
fix_optional_param_default
branch
from
e513171
to
63f3124
Compare
yachub
force-pushed
the
fix_optional_param_default
branch
from
63f3124
to
33c1e64
Compare
genebean
approved these changes
Jul 30, 2021
alexjfisher
reviewed
Aug 25, 2021
| @@ -35,7 +35,7 @@ | |||
| Boolean $checksum = true, | |||
| Optional[String] $digest_url = undef, | |||
| Optional[String] $digest_string = undef, | |||
| Optional[Enum['none', 'md5', 'sha1', 'sha2','sha256', 'sha384', 'sha512']] $digest_type = 'md5', # bad default! | |||
| Optional[Enum['none', 'md5', 'sha1', 'sha2','sha256', 'sha384', 'sha512']] $digest_type = undef, | |||
There was a problem hiding this comment.
Correct fix was possibly just
Suggested change
| Optional[Enum['none', 'md5', 'sha1', 'sha2','sha256', 'sha384', 'sha512']] $digest_type = undef, | |
| Enum['none', 'md5', 'sha1', 'sha2','sha256', 'sha384', 'sha512']] $digest_type = 'md5', |
??
Not sure. Maybe we could drop the camptocamp/archive compatibility code at some point???
alexjfisher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This fixes a test failure detected by the recently added GitHub Actions workflow.
This Pull Request (PR) fixes the following issues
Fixes #450