Bug fix when passing multiple headers #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apprach allowss optional_switch to accept array of values and bulk assign to a flag
|
I think you should add a test to https://github.com/voxpupuli/puppet-archive/blob/master/spec/unit/puppet/provider/archive/curl_spec.rb which has multiple headers, in a separate PR, so that we can see the failure, then fix the problem in this PR on top of the other PR, so that we can see the fix. |
At time of converting to parameters flatten the array
|
I submitted just the test case as it's own PR #483 |
kenyon
reviewed
Jan 12, 2023
Co-authored-by: Kenyon Ralph <kenyon@kenyonralph.com>
kenyon
approved these changes
Jan 13, 2023
bastelfreak
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Apprach allowss optional_switch to accept array of values and bulk assign to a flag
This Pull Request (PR) fixes the following issues
Fixes #481