Use expect() instead of .should #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
force-pushed
the
remove-should-style
branch
from
64817de
to
350304b
Compare
deric
suggested changes
Feb 21, 2023
spec/lib/augeas_spec/fixtures.rb
Outdated
|
|
||
| # Check for transaction success after, as it's less informative | ||
| txn.any_failed?.should_not eq(true) | ||
| expect(txn.any_failed?).to be_false |
There was a problem hiding this comment.
Suggested change
| expect(txn.any_failed?).to be_false | |
| expect(txn.any_failed?).to be_nil |
spec/lib/augeas_spec/fixtures.rb
Outdated
| againlogs.should eq([]), "expected no change on second run (idempotence check),\n got: #{againlogs.inspect}" | ||
| txn_idempotent.any_failed?.should_not eq(true), 'expected no change on second run (idempotence check), got a resource failure' | ||
| expect(againlogs).to eq([]), 'expected no change on second run (idempotence check)' | ||
| expect(txn_idempotent.any_failed?).to be_false, 'expected no change on second run (idempotence check), got a resource failure' |
There was a problem hiding this comment.
The check should be comparing to be_nil
Suggested change
| expect(txn_idempotent.any_failed?).to be_false, 'expected no change on second run (idempotence check), got a resource failure' | |
| expect(txn_idempotent.any_failed?).to be_nil, 'expected no change on second run (idempotence check), got a resource failure' |
|
Interesting. I looked at the implementation (https://github.com/puppetlabs/puppet/blob/aa05e8df814b8a6655b33ebf25c3fe0915c8f0d5/lib/puppet/transaction.rb#L213-L218) and that uses |
This removes deprecation warnings from the process output. It also uses eq([]) instead of be_empty since it's easier to debug: the diff is more useful.
ekohl
force-pushed
the
remove-should-style
branch
from
350304b
to
9e3d0e5
Compare
bastelfreak
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes deprecation warnings from the process output.
It also uses eq([]) instead of be_empty since it's easier to debug: the diff is more useful.