Bug fix + Custom Fileset From Manifest #11

Closed
wants to merge 8 commits into
from

Conversation

Projects
None yet
5 participants
@solarisfire

Put in all the code to create custom filesets from the manifest, updated the documentation...

Stephen Greenham added some commits Feb 21, 2012

@@ -102,29 +109,36 @@
owner => 'bacula',
group => 'bacula',
content => template($template),
- notify => Service['bacula-director'],

This comment has been minimized.

Show comment Hide comment
@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

file { '/etc/bacula/bacula-dir.d':
ensure => directory,
owner => 'bacula',
group => 'bacula',
- before => Service['bacula-director'],

This comment has been minimized.

Show comment Hide comment
@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

}
file { '/etc/bacula/bacula-dir.d/empty.conf':
ensure => file,
- before => Service['bacula-director'],

This comment has been minimized.

Show comment Hide comment
@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

@solarisfire

solarisfire Feb 22, 2012

Changed because we develop on CentOS.

}
# Register the Service so we can manage it through Puppet
- service { 'bacula-director':
+ notify { 'Running service': }

This comment has been minimized.

Show comment Hide comment
@solarisfire

solarisfire Feb 22, 2012

This works on CentOS but needs testing on Debian at some point.

@solarisfire

solarisfire Feb 22, 2012

This works on CentOS but needs testing on Debian at some point.

Stephen Greenham added some commits Feb 22, 2012

Added ability to define custom storage pools from the manifest, and r…
…emoved hard coded storage pools from the director template. Also updated documentation.
Major refactoring of the way jobs are defined, removed all of the job…
…s in the template and allowed for jobs to be defined from the manifest. Squashed an absolute ton of bugs I carelessly introduced in a previous commit. Updated the documentation.
@blkperl

This comment has been minimized.

Show comment Hide comment
@blkperl

blkperl May 1, 2012

Member

Hi @solarisfire

Looks like you still need to sign the CLA. Go ahead and comment here or on the ticket when you have signed it.

https://projects.puppetlabs.com/contributor_licenses/sign

Member

blkperl commented May 1, 2012

Hi @solarisfire

Looks like you still need to sign the CLA. Go ahead and comment here or on the ticket when you have signed it.

https://projects.puppetlabs.com/contributor_licenses/sign

@ccaum

This comment has been minimized.

Show comment Hide comment
@ccaum

ccaum Oct 2, 2012

Contributor

Any update on this? Has the CLA been signed?

Contributor

ccaum commented Oct 2, 2012

Any update on this? Has the CLA been signed?

@puppetcla

This comment has been minimized.

Show comment Hide comment
@puppetcla

puppetcla Aug 14, 2014

Waiting for CLA signature by @solarisfire

@solarisfire - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

Waiting for CLA signature by @solarisfire

@solarisfire - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

@underscorgan

This comment has been minimized.

Show comment Hide comment
@underscorgan

underscorgan Dec 19, 2014

Contributor

@solarisfire thanks for your contribution. We no longer require CLAs, but this at least needs to be rebased (and possibly additional work), and we haven't heard from you in a while so I'm going to close this PR for now. If this is still functionality you're interested in having added to the module, please resubmit.

Contributor

underscorgan commented Dec 19, 2014

@solarisfire thanks for your contribution. We no longer require CLAs, but this at least needs to be rebased (and possibly additional work), and we haven't heard from you in a while so I'm going to close this PR for now. If this is still functionality you're interested in having added to the module, please resubmit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment